Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let AutoUpdate class throw exceptions #42

Open
ttimot24 opened this issue Sep 8, 2018 · 1 comment
Open

Let AutoUpdate class throw exceptions #42

ttimot24 opened this issue Sep 8, 2018 · 1 comment
Labels
enhancement help wanted

Comments

@ttimot24
Copy link
Contributor

ttimot24 commented Sep 8, 2018

Hi!

Please remove the @ chars from the class, so one can handle connection exceptions in their program. Exceptions are an important part of object oriented programming.

Thanks!
@thelfensdrfer
Copy link
Member

You are right! Feel free to open a pull request.

thelfensdrfer added a commit that referenced this issue Oct 5, 2018
@thelfensdrfer
Added a few exceptions (#42) and fixed wrong docblocks and return types.
e893d88
thelfensdrfer referenced this issue Oct 5, 2018
@thelfensdrfer
Only download via curl if the url is valid
f1f19c0
thelfensdrfer added a commit that referenced this issue Dec 28, 2018
@thelfensdrfer
Added todos for throwing exceptions, #42
68872c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thelfensdrfer @ttimot24