Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made pip-install explicitly install setuptools to work with Python3.12. #315

Merged
merged 1 commit into from
Sep 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/pip-install.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ jobs:
- name: Install cibuildwheel
run: |
python -m pip install -U pip
python -m pip install setuptools
python -m pip install cibuildwheel

- name: Build wheel on Linux
Expand Down
9 changes: 0 additions & 9 deletions setup.py
Original file line number Diff line number Diff line change
@@ -1,15 +1,6 @@
import os
import sys

# if sys.version_info >= (3, 12):
# # For Python 3.12 and above, use setuptools
# from setuptools.command.clean import clean
# else:
# # For Python versions below 3.12, use distutils
# from distutils.command.clean import clean

from glob import glob

from setuptools import Extension, find_packages, setup
from setuptools.command.build_ext import build_ext
from setuptools.command.develop import develop
Expand Down
Loading