Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android Bootcamp] Project 2: GridImageSearch - Ready for Review #1

Open
Vikramjeet-Singh opened this issue Feb 13, 2015 · 1 comment

Comments

@Vikramjeet-Singh
Copy link
Owner

My app GridImageSearch is complete. Please review. /cc @codepathreview @codepath
Please let me know if I missed anything.

@codepathreview
Copy link

👍 Excellent work, Vikramjeet!! Few notes after checking the code:

  • Good to see you used a filters object to represent the filters to apply to the query
  • Consider using Parcelable instead of Serializable
  • Properly used spinners (with populated values) to allow users to select filters
  • Nice effort on improving the UI/UX
  • Nice job adding the share intent to the image detail view!
  • Nice to see you added the search box to the ActionBar!
  • Consider creating a static method in a Helper/Utility class for common methods such as checking for internet
  • Consider adding progress bars to your app whenever a network request goes out in addition to the placeholder images.

Also, here's a more detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants