Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix chunk_convert.sh to handle output_dir correctly #415

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Fix chunk_convert.sh to handle output_dir correctly #415

merged 1 commit into from
Dec 12, 2024
+7 −5

Conversation

Leon-Sander
Copy link
Contributor

Fixes #414

Running the command for multiple devices and multiple files leads to an error:

NUM_DEVICES=2 NUM_WORKERS=15 marker_chunk_convert /tmp/marker_input /tmp/marker_output
Running convert.py on GPU 0
Usage: marker [OPTIONS] IN_FOLDER
Try 'marker --help' for help.

Error: Got unexpected extra argument (/tmp/marker_output)

This pull request fixes the bash script and calls marker correctly. I also added a line which makes sure the output folder exists, and creates it if not.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@Leon-Sander
Copy link
Contributor Author

Leon-Sander commented Dec 5, 2024 •
edited
Loading

I have read the CLA Document and I hereby sign the CLA

@Leon-Sander
Copy link
Contributor Author

recheck

github-actions bot added a commit that referenced this pull request Dec 5, 2024
@github-actions
@Leon-Sander has signed the CLA in #415
1b95cc9
@VikParuchuri
Copy link
Owner

Thanks for the PR!

@VikParuchuri VikParuchuri merged commit 3d2cf04 into VikParuchuri:master Dec 12, 2024
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chunk_convert.sh throws "Got unexpected extra argument" error
2 participants
@Leon-Sander @VikParuchuri