Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add encoding explicitly to all calls to open #409

Closed

Conversation

HDembinski
Copy link

Closes #406

My auto-formatter introduced some format changes. If you don't want this, please set up pre-commit to apply your own autoformatter, see #408

Copy link
Contributor

github-actions bot commented Dec 2, 2024

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

@HDembinski
Copy link
Author

This is absurd. I never signed such nonsense when I contributed to larger OSS projects than this. You automatically have these rights as per your OSS license.

@VikParuchuri
Copy link
Owner

As per my comment on the issue, I'm closing this. Thanks for the PR

@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception on Windows related to default encoding for Python's open
2 participants