Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Criteria Architecture #896

Open
lenybernard opened this issue Apr 11, 2017 · 0 comments
Open

Refactor Criteria Architecture #896

lenybernard opened this issue Apr 11, 2017 · 0 comments
Assignees
@lenybernard

Comments

@lenybernard
Copy link
Contributor

lenybernard commented Apr 11, 2017 •
edited by talbotseb
Loading

Criteria comparison is too strict (1 === true => false)

Description

I want a widget to show only for authenticated users then Criterias is supposed to be the solution:
I create my widget and specify the following criteria request_user equal 1.

But the content isn't displayed.
After digging, the following line : dd5633f#diff-a3d5dd0acce1865308353da827fd2dadR62 is problematic because the current comparison is 1 === true.

Resolution Ideas

Don't use true and false and prefer a unique equal operand.
Check #897

Related to

Bundle -- -- --
Analytics Page
Blog Query
BusinessEntity Seo
BusinessPage Sitemap
Core Template
Criteria ✔ Twig
Filter User
Form ViewReference
I18n Widget
Media WidgetMap
@lenybernard lenybernard mentioned this issue Apr 11, 2017
Closed
@ghost ghost assigned lenybernard Apr 11, 2017
@ghost ghost added the in progress label Apr 11, 2017
@talbotseb talbotseb changed the title Criteria comparison is too strict (1 === true => false) Refactor Criteria Architecture Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lenybernard lenybernard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lenybernard @alexislefebvre