Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes SPI communication for sync implementation of the BME280 driver. I didn't fix async impl, because I couldn't get it to compile. I'd need to be investigate the problem first and I don't have much time right now. @VersBinarii try to run
cargo b --features=async
and let me know what you get.I also upgraded stm32f4xx_hal dev-dependency because I build anything due to conflicts
Related issues
Testing
Tested on stm32f446re and bmp280
Output:
Note: Humidity == 0.0 to be expected, bmp280 doesn't support it.