Another step toward full unrolling of loops: cache extracted body #131
Conversation
Also: * rename a few more things * remove unnecessary derives
| /// Exists only to stabilize function order for lit test output. | ||
| func_creation_order: RefCell<Vec<String>>, |
There was a problem hiding this comment.
If we care about the performance impact of this, we would need to add a cmd line flag for lit testing I think.
There was a problem hiding this comment.
I would measure first before jumping into tweaking performance but if so I would guard the ordering code into a compile flag, debug builds is sorted, release builds not necessarily. Vanguard is going to use the release builds to we get both benefits
There was a problem hiding this comment.
I had considered using debug build flag but I think the GitHub CI runs a release build so there would be intermittent failures here.
Excerpt from the CI log:
circom-unknown> Running phase: configurePhase
circom-unknown> [naersk] cargo_version (read): 1.74.0
circom-unknown> [naersk] cargo_message_format (set): json-diagnostic-rendered-ansi
circom-unknown> [naersk] cargo_release: --release
circom-unknown> [naersk] cargo_options:
circom-unknown> [naersk] cargo_build_options: $cargo_release -j "$NIX_BUILD_CORES" --message-format=$cargo_message_format
circom-unknown> [naersk] cargo_test_options: $cargo_release -j "$NIX_BUILD_CORES"
...
circom-unknown> Running phase: buildPhase
circom-unknown> cargo build $cargo_release -j "$NIX_BUILD_CORES" --message-format=$cargo_message_format
...
circom-unknown> buildPhase completed in 1 minutes 35 seconds
circom-unknown> Running phase: checkPhase
circom-unknown> cargo test $cargo_release -j "$NIX_BUILD_CORES"
There was a problem hiding this comment.
We could go back to a manual CI script then, to get more control. I honestly don't like leaving nix handle everything
Avoid creating identical extracted functions when the same loop is encountered with different iteration counts.
| /// Exists only to stabilize function order for lit test output. | ||
| func_creation_order: RefCell<Vec<String>>, |
There was a problem hiding this comment.
I would measure first before jumping into tweaking performance but if so I would guard the ordering code into a compile flag, debug builds is sorted, release builds not necessarily. Vanguard is going to use the release builds to we get both benefits
No description provided.