Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbt 1.8 has deprecated tests in favour of data_tests #328

Open
elyobo opened this issue Jun 5, 2024 · 4 comments
Open

dbt 1.8 has deprecated tests in favour of data_tests #328

elyobo opened this issue Jun 5, 2024 · 4 comments

Comments

@elyobo
Copy link
Contributor

elyobo commented Jun 5, 2024

See https://docs.getdbt.com/docs/build/data-tests#new-data_tests-syntax

tests should be renamed to data_tests for future compatibility, although this is a BC break and so it's not clear at which point to make this change to me.

@adamribaudo-velir
Copy link
Collaborator

Working on adding unit tests here but it will take a while to migrate all of them

https://github.com/Velir/dbt-ga4/tree/feature/dbt-unit-tests

@elyobo
Copy link
Contributor Author

elyobo commented Jun 7, 2024

I'm not suggesting a change of the test suites themselves (although adding unit tests sounds great!), just that the name of the existing tests config item has moved to data_tests and it's generating a warning because of that; works fine for now but will presumably go away in a future release.

@adamribaudo-velir
Copy link
Collaborator

Fair. I was going to wrap it all into 1 PR but we could update to data_tests in its own change.

@elyobo
Copy link
Contributor Author

elyobo commented Jun 8, 2024

Probably no rush, I don't know when they'll remove them entirely but presumably a 1.9 release at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants