You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've been exploring the rabpro package and have found it to be a great tool. During my usage, I came across two minor issues in the documentation that I thought to bring to your attention for clarification and correction:
Environment Variable Setup Instruction:
In the section describing how to change the path using os.environ['RABPRO_DATA'] = 'path/to/rabpro/data', it might be helpful to note that this step needs to be done before importing the package. A small comment or note in the documentation could assist new users in correctly setting up their environment.
Function Name Mismatch:
In the section for downloading the MERIT DEM data, the function call is listed as data_utils.download_merit_dem("n30w120", your_username, your_password). However, I believe the correct function name should be download_merit_hydro.
Thank you for developing and maintaining.
Best regards,
Ralf
The text was updated successfully, but these errors were encountered:
Thanks Ralf, I've fixed the Function Name Mismatch typo. Can you tell me what happens if you don't set RABPRO_DATA before importing? To me, that should still work after importing.
Hello rabpro team,
I've been exploring the rabpro package and have found it to be a great tool. During my usage, I came across two minor issues in the documentation that I thought to bring to your attention for clarification and correction:
Environment Variable Setup Instruction:
In the section describing how to change the path using os.environ['RABPRO_DATA'] = 'path/to/rabpro/data', it might be helpful to note that this step needs to be done before importing the package. A small comment or note in the documentation could assist new users in correctly setting up their environment.
Function Name Mismatch:
In the section for downloading the MERIT DEM data, the function call is listed as data_utils.download_merit_dem("n30w120", your_username, your_password). However, I believe the correct function name should be download_merit_hydro.
Thank you for developing and maintaining.
Best regards,
Ralf
The text was updated successfully, but these errors were encountered: