Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

diva charm doesn't work on fabric #4758

Open
LeoBeliik opened this issue Oct 7, 2024 · 3 comments
Open

diva charm doesn't work on fabric #4758

LeoBeliik opened this issue Oct 7, 2024 · 3 comments
Labels
1.20.1 Issue has been reported for version 1.20.1 of Minecraft bug A bug confirmed The maintainers will take a look at this.

Comments

@LeoBeliik
Copy link
Contributor

Mod Loader

Fabric

Minecraft Version

1.20.1

Botania version

1.20.1-446

Modloader version

Fabric 0.16.5

Modpack info

No response

The latest.log file

Issue description

No matter how much you punch an enemy the charm never triggers, it works in forge (after 2 or 3 punches)

Steps to reproduce

  • equip the diva charm
  • get a source of mana
  • spawn 2 husks
  • punch them
    they'll be punch to death before the charm effect ever triggers

Other information

No response
@TheRealWormbo TheRealWormbo mentioned this issue Oct 8, 2024
Closed
@TheRealWormbo
Copy link
Collaborator

Likely caused by the fix to #4561.

@TheRealWormbo TheRealWormbo added bug A bug confirmed The maintainers will take a look at this. 1.20.1 Issue has been reported for version 1.20.1 of Minecraft labels Oct 8, 2024
@TheRealWormbo
Copy link
Collaborator

It works fine when launching from IntelliJ directly and only breaks when running the same compiled version through e.g. Prism, and I don't know why.

@TheRealWormbo TheRealWormbo mentioned this issue Dec 16, 2024
Open
@TheRealWormbo
Copy link
Collaborator

Confirmed to be a compatibility issue with Trinkets 3.7.2, which slightly changed the semantics of its onEquip and onUnequip events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.20.1 Issue has been reported for version 1.20.1 of Minecraft bug A bug confirmed The maintainers will take a look at this.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TheRealWormbo @LeoBeliik