Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Booking: Clear date filter when past that date #1053

Closed
maxlk96 opened this issue Oct 31, 2024 · 3 comments
Closed

Booking: Clear date filter when past that date #1053

maxlk96 opened this issue Oct 31, 2024 · 3 comments
Labels
enhancement New feature or request triage

Comments

@maxlk96
Copy link

maxlk96 commented Oct 31, 2024

When opening CC bookings page, it saves the filters I've set to show the same one's next time I open the page, which is convenient.

When that date has passed, it would be great if the date filter gets reset/forgets the filter, as it does not show booking lying in history.

@maxlk96 maxlk96 added enhancement New feature or request triage labels Oct 31, 2024
@blt950
Copy link
Member

blt950 commented Nov 30, 2024

To my knowledge that is not possible to do with the table dependency we use. Question is if we should in general highlight today's bookings somehow? Like a tiny bit yellow background or something on those?

@blt950
Copy link
Member

blt950 commented Dec 21, 2024

I just recalled that filter save function is a "feature" rather than a "bug". The main purpose was that if you filter you FIR, you don't need to select FIR each time you open bookings 😄 Though I'll add the "today" highlight as I think that would be useful regardless

blt950 added a commit that referenced this issue Dec 21, 2024
@blt950
Copy link
Member

blt950 commented Dec 21, 2024

The solution was to replace the date with "Today" text. This will also help if your browser saves the filter, so next day you open bookings, it'd show today's bookings as well - partially resolving the original issue.

This will be available in the next update.

@blt950 blt950 closed this as completed Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage
Projects
None yet
Development

No branches or pull requests

2 participants