Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: binder module not found #217

Closed
wants to merge 1 commit into from
Closed

fix: binder module not found #217

wants to merge 1 commit into from

Conversation

jardon
Copy link
Member

@jardon jardon commented Oct 3, 2024 •
edited
Loading

the anbox-modules has been deprecated and archived. this moves to the intree binder module

Potentially closes Vanilla-OS/vanilla-system-operator#112

@jardon jardon changed the title fix: test waydroid fix fix: binder module not found Oct 3, 2024
@jardon jardon force-pushed the fix/waydroid-modules branch 3 times, most recently from 943cab9 to 9ecb1e3 Compare October 3, 2024 23:56
@jardon
Copy link
Member Author

jardon commented Oct 4, 2024

saving this for later

https://docs.kernel.org/admin-guide/binderfs.html

@jardon
Copy link
Member Author

jardon commented Oct 4, 2024 •
edited
Loading 

args = Namespace(log='/var/lib/waydroid/waydroid.log', details_to_stdout=False, verbose=False, quiet=False, 
wait_for_init=False, action='init', images_path='/var/lib/waydroid/images', force=False, 
system_channel='https://ota.waydro.id/system', vendor_channel='https://ota.waydro.id/vendor', rom_type='lineage', 
system_type='VANILLA', cache={}, work='/var/lib/waydroid', config='/var/lib/waydroid/waydroid.cfg', sudo_timer=True, 
timeout=1800, logfd=<_io.TextIOWrapper name='/var/lib/waydroid/waydroid.log' mode='a+' encoding='UTF-8'>, 
arch='x86_64', system_ota='https://ota.waydro.id/system/lineage/waydroid_x86_64/VANILLA.json', 
vendor_type='MAINLINE', vendor_ota='https://ota.waydro.id/vendor/waydroid_x86_64/MAINLINE.json')

@jardon
Copy link
Member Author

jardon commented Oct 4, 2024

it looks like for modules, we could either run this helper or just write a short script to do what that helper script does

@jardon jardon force-pushed the fix/waydroid-modules branch from ef76f5b to 39d3405 Compare October 4, 2024 13:15
@jardon
fix: binder module not loaded
06420e1 
- remove ashmem module
- use binder intree module
- add modprobe options
@jardon jardon force-pushed the fix/waydroid-modules branch from 9857bae to 06420e1 Compare October 4, 2024 15:48
@jardon jardon marked this pull request as ready for review October 4, 2024 15:48
@kbdharun kbdharun requested a review from axtloss October 4, 2024 17:09
@axtloss
Copy link
Member

axtloss commented Oct 4, 2024

built in debian binder module doesn't work, this pr wouldn't really fix anything

@jardon
Copy link
Member Author

jardon commented Oct 4, 2024

Can you be more specific about how it doesn't work?

I'm not saying that you're wrong. I haven't been able to get waydroid working at all on vanilla so I can't exactly verify. So I'm just going off of if it loads and what waydroid does to configure on Debian

@axtloss
Copy link
Member

axtloss commented Oct 4, 2024

It simply doesn't work, it shows as loaded but does not do anything.
Either way, I am reworking the way waydroid works, I dont see why we should put more effort intofixing an inherently broken way of doing it

@mirkobrombin
Copy link
Member

Can we close this since the plan is to have a sysext?

@jardon jardon closed this Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbdharun kbdharun Awaiting requested review from kbdharun

@mirkobrombin mirkobrombin Awaiting requested review from mirkobrombin

@axtloss axtloss Awaiting requested review from axtloss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Waydroid/binder module not working
3 participants
@jardon @axtloss @mirkobrombin