Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Switch search to a search filter #13

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

MikeRatcliffe
Copy link

@MikeRatcliffe MikeRatcliffe commented Sep 8, 2024

Fixes #14

  • We needed to upgrade fontawesome in order to have a grip icon for the find box. I removed the built-in css file and used the node module instead. A couple of icons now have different names, which have been updated.
  • I added JQueryUI in order to make use of the drag functionality (for the search box).
  • pull-left used to be a bootstrap class that used float: left, but they dropped it a long time ago. The only reason pull-left still works is because it is a class used in fontawesome, which they have now also removed. Anyhow, bootstrap calls it float-left in the bootstrap version in this build, so it is renamed in multiple files.
  • The bulk of the new filter functionality is in browse.js and search.js.
  • The resize listener that moved the nav panel has been moved to views/layout.twig where it belongs.
  • The new css class table-striped-rookie replaces table-striped. This css class is improved and preserves zebra striping in tables where some rows are hidden.

@Fenopy Fenopy merged commit f94fe88 into VRPirates:main Sep 9, 2024
@MikeRatcliffe MikeRatcliffe deleted the change-search-to-filter branch September 9, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change search to search filter
2 participants