Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limiting Pitch Range #1702

Open
Patchethium opened this issue Jan 10, 2024 · 1 comment · May be fixed by #1942
Open

Limiting Pitch Range #1702

Patchethium opened this issue Jan 10, 2024 · 1 comment · May be fixed by #1942

Comments

@Patchethium
Copy link
Contributor

As discussed in #1026, we can ease the tuning by limiting the range as shown in #1026 (comment), at least we should provide an option.

The problem is how should the range be obtained. There're plenty of ways, the best approach seems to be including them in meta.json and provide an API from the engine side that GUI can access. However, that part seems to be done by the owner @Hiroshiba when he releases new models. Or is the building script already published somewhere? I'd like to know further about the building process at current time.

To prevent the trouble, generating them on the fly seems to be a choice as well. Therefore, there goes the other two ways:

  1. Do it in the engine and provide a new API. The engine calculates range info on the fly.
  2. Do it in the GUI utilizing the existing APIs. The engine calculates range info on the fly.

With the pre-compute method as the third choice,

  1. Do it in the engine and provide a new API. The engine grabs the pre-computed range info from meta.json.

Please feel free to leave comment for these choices or give the instruction of modifying building process (if possible).

@Patchethium
Copy link
Contributor Author

Oh I found where you put the meta.json, seems I just need to add the range info here https://github.com/VOICEVOX/voicevox_resource, I'll go with plan 3 then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants
@Patchethium and others