Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ortho 7 - group table filters: performance, bug and UX #1303

Open
bobular opened this issue Dec 18, 2024 · 1 comment
Open

Ortho 7 - group table filters: performance, bug and UX #1303

bobular opened this issue Dec 18, 2024 · 1 comment
Assignees

Comments

@bobular
Copy link
Member

bobular commented Dec 18, 2024

performance

Chrome dev tools performance tab has a 6x slower CPU throttling - use it to measure the "page load" on the biggest group: https://beta.orthomcl.org/orthomcl.b7/app/record/group/OG7_0000011

When it's done you can interact with the page, but with 6x slower CPU :-)
Try clicking the second level checkboxes in the Organism filter - every 1/2 second or so.
You should see that there are major delays to updates - replicating what our colleague found.

Try removing domain architecture column to see if that makes a difference.

500, 250 rows instead? Or even 20.

Filtering logic can be improved with Set lookup for organisms (selectedSpecies) and proteins (proteinFilterIds)

Look into windowing libs (only render the rows you need) - could be a heavy lift to incorporate into Mesa...

bug

Under certain circumstances, particularly with large groups, after interacting with filter popovers, the page is inactive because the popover backdrop (it's basically a modal) has not been removed. The popover may still be there as a "ghost" and you can click on parts of it.

Let's try updating MUI to see if that helps.

UX

Due to the delays described above there is some confusion about how to dismiss the popover dialogues and whether or not this is what activates the filter.

If the performance issues are fixed, maybe we can get away with just having an x top right to dismiss the filter popovers (in addition to clicking elsewhere, and pressing ESC.

Another suggestion was to have cancel and apply buttons, which would be a bit more work and require further consultation before investing in that.

Having sticky items at the top of the popover would be useful in either case, e.g.
image

@bobular bobular self-assigned this Dec 19, 2024
@bobular
Copy link
Member Author

bobular commented Dec 19, 2024

UX update

Dave suggested that we need visual feedback for when the table is not yet updated upon filtering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant