You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When it's done you can interact with the page, but with 6x slower CPU :-)
Try clicking the second level checkboxes in the Organism filter - every 1/2 second or so.
You should see that there are major delays to updates - replicating what our colleague found.
Try removing domain architecture column to see if that makes a difference.
500, 250 rows instead? Or even 20.
Filtering logic can be improved with Set lookup for organisms (selectedSpecies) and proteins (proteinFilterIds)
Look into windowing libs (only render the rows you need) - could be a heavy lift to incorporate into Mesa...
bug
Under certain circumstances, particularly with large groups, after interacting with filter popovers, the page is inactive because the popover backdrop (it's basically a modal) has not been removed. The popover may still be there as a "ghost" and you can click on parts of it.
Let's try updating MUI to see if that helps.
UX
Due to the delays described above there is some confusion about how to dismiss the popover dialogues and whether or not this is what activates the filter.
If the performance issues are fixed, maybe we can get away with just having an x top right to dismiss the filter popovers (in addition to clicking elsewhere, and pressing ESC.
Another suggestion was to have cancel and apply buttons, which would be a bit more work and require further consultation before investing in that.
Having sticky items at the top of the popover would be useful in either case, e.g.
The text was updated successfully, but these errors were encountered:
performance
Chrome dev tools performance tab has a 6x slower CPU throttling - use it to measure the "page load" on the biggest group: https://beta.orthomcl.org/orthomcl.b7/app/record/group/OG7_0000011
When it's done you can interact with the page, but with 6x slower CPU :-)
Try clicking the second level checkboxes in the Organism filter - every 1/2 second or so.
You should see that there are major delays to updates - replicating what our colleague found.
Try removing domain architecture column to see if that makes a difference.
500, 250 rows instead? Or even 20.
Filtering logic can be improved with Set lookup for organisms (
selectedSpecies
) and proteins (proteinFilterIds
)Look into windowing libs (only render the rows you need) - could be a heavy lift to incorporate into Mesa...
bug
Under certain circumstances, particularly with large groups, after interacting with filter popovers, the page is inactive because the popover backdrop (it's basically a modal) has not been removed. The popover may still be there as a "ghost" and you can click on parts of it.
Let's try updating MUI to see if that helps.
UX
Due to the delays described above there is some confusion about how to dismiss the popover dialogues and whether or not this is what activates the filter.
If the performance issues are fixed, maybe we can get away with just having an
x
top right to dismiss the filter popovers (in addition to clicking elsewhere, and pressing ESC.Another suggestion was to have
cancel
andapply
buttons, which would be a bit more work and require further consultation before investing in that.Having sticky items at the top of the popover would be useful in either case, e.g.
The text was updated successfully, but these errors were encountered: