Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions should be caught when setting up the workspaces and cause jobs to... #6

Open
3 tasks
Foxcapades opened this issue Jun 13, 2022 · 1 comment
Open
3 tasks
Assignees
Labels
todo Required development task

Comments

@Foxcapades
Copy link
Member

Foxcapades commented Jun 13, 2022

What should happen when the creation/setup of a job fails in the platform before the job is executed?

  • Should we assume it's a hiccup and clear out the job with a 500 so they can try resubmitting?

  • Should we just fail the job before it starts?

  • Submitting a job to the DB (we didn't even manage to record the job)

  • Submitting a workspace to S3 (we recorded the job in the DB but S3 operation(s) failed)

  • Submitting a job to the queue (we recorded the job in the DB and created an S3 workspace, but rabbit threw an exception)

@Foxcapades Foxcapades added the todo Required development task label Jun 13, 2022
@Foxcapades Foxcapades self-assigned this Jun 13, 2022
@Foxcapades
Copy link
Member Author

@dmgaldi points out that if we get a client timeout when creating and S3 workspace and fail the request, all subsequent requests to create that job will fail due to the workspace already existing (s3-workspaces throws an exception for double creating a workspace)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
todo Required development task
Projects
None yet
Development

No branches or pull requests

1 participant