Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Narrow the defintion for registry field in Manifest. #114

Open
u-train opened this issue Mar 7, 2023 · 0 comments
Open

Narrow the defintion for registry field in Manifest. #114

u-train opened this issue Mar 7, 2023 · 0 comments

Comments

@u-train
Copy link
Contributor

u-train commented Mar 7, 2023

Right now, a registry field is simply an arbitrary string. It would be nice to have a stricter definition since a registry has to point to a valid URL or directory path (the latter which is internal).

One choice is to specify that a registry has to be a valid URI. It still allows the user to specify the scheme being used (file vs http/https). We can always look at the scheme and then error if isn't valid. And, this type can be applied throughout the codebase, ensuring that we're not playing with some string, but URI specifically.

Another option is make an internal enumeration which would have File or URL. Though, I think it's just a smaller subset of a URI.

@u-train u-train changed the title Registry field could be a URI instead of a string. Narrow the defintion for registry field in Manifest. Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant