Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update source files for photon emitter, custom ptracer, and relevant examples #2

Merged
merged 21 commits into from
Oct 24, 2024

Conversation

andrewgait
Copy link
Collaborator

@andrewgait andrewgait commented Oct 8, 2024

Updated source files from previous Manchester fork of Mitsuba3 for photon emitter and custom ptracer to match recent changes in mitsuba3 and drjit.

TODO:

  • add examples from previous fork and check results
  • run tests on HEP cluster with code from this repository

@andrewgait andrewgait linked an issue Oct 8, 2024 that may be closed by this pull request
5 tasks
@andrewgait andrewgait marked this pull request as ready for review October 15, 2024 09:26
@andrewgait andrewgait changed the title Add source files for photon emitter and custom ptracer Update source files for photon emitter, custom ptracer, and relevant examples Oct 16, 2024
@andrewgait andrewgait self-assigned this Oct 16, 2024
Copy link
Collaborator Author

@andrewgait andrewgait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments as a "review" of sorts; this is good to merge once they have been dealt with.

MPhys/Direct import/python input.ipynb Outdated Show resolved Hide resolved
MPhys/Rich_Geometry/One emitter for One photon .ipynb Outdated Show resolved Hide resolved
MPhys/Single_Emitter/Write_binary_file.ipynb Outdated Show resolved Hide resolved
MPhys/Single_Emitter/Write_binary_file.ipynb Outdated Show resolved Hide resolved
MPhys/Single_Emitter/cluster_instructions_history.txt Outdated Show resolved Hide resolved
MPhys/Single_Emitter/mitsuba_hello.py Outdated Show resolved Hide resolved
MPhys/Single_Emitter/single_emitter_plotting_variants.py Outdated Show resolved Hide resolved
MPhys/Single_Emitter/single_emitter_test_new_int1000.py Outdated Show resolved Hide resolved
src/emitters/photon_emitter_old.cpp Show resolved Hide resolved
@andrewgait
Copy link
Collaborator Author

Everything is now updated, but the cluster is currently down for maintenance (Thursday 17th October). Once it is back tomorrow I hope to rerun the scripts on there to (a) get results for the updated version of mitsuba3, and (b) get log-log plots for scaling performance. Once these results and plots are created, this PR will be good to merge.

I have also suggested some further investigative work of performance in the following tickets:

@andrewgait
Copy link
Collaborator Author

Experiments on the cluster are now complete and this branch (which has got a bit ridiculous in terms of the number of files) is now going to be merged. I have obtained new figures compared to those detailed in the issue which I have written up into a new directory structure for experiments within the MPhys/Single_Emitter directory (hence the large number of extra files and a certain amount of duplication). Given that the MPhys directory is unlikely to ever be merged into the main branch of Mitsuba itself, I don't think there's any harm in leaving the dev branch like this, and we could also choose (eventually) to keep the MPhys directory off the main branch of this fork, to make it easier to do any PR of code that (eventually) could end up in the main branch of Mitsuba.

The experiment writeup is at https://github.com/UoMResearchIT/mitsuba3-manchester/blob/1-update-to-include-manchester-photon-emitter-code/MPhys/Single_Emitter/performance_scaling_experiments/experiment_01_scaling_n_photons.md.

@andrewgait andrewgait merged commit f8d13e5 into dev Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to include Manchester photon emitter code
1 participant