Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a PR on the main mitsuba repository with the code changes to add the photon_emitter on this fork #16

Open
5 tasks
andrewgait opened this issue Nov 15, 2024 · 0 comments

Comments

@andrewgait
Copy link
Collaborator

This may be more relevant in a few sprints from now, but I thought it worth creating a ticket to discuss what to do with the new code on this fork; ideally, I imagine we want to merge our new emitter into the main mitsuba3 repository.

To that end, the process will be to add the relevant code that we want to merge into the main mitsuba3 repository to the main branch of this fork and then create a pull request from there; and keep anything we don't want to merge into the main mitsuba3 repository (e.g. the performance & scaling tests we've run) on the dev branch here (or indeed, on any other branch on this fork should that be necessary). If desired we could make a tutorial about the photon_emitter, but that would be worth its own ticket.

Below is a list of work that will need to be done before this can happen, which we can add to as necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant