Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to include Manchester photon emitter code #1

Closed
5 tasks done
andrewgait opened this issue Oct 8, 2024 · 3 comments · Fixed by #2
Closed
5 tasks done

Update to include Manchester photon emitter code #1

andrewgait opened this issue Oct 8, 2024 · 3 comments · Fixed by #2
Assignees

Comments

@andrewgait
Copy link
Collaborator

andrewgait commented Oct 8, 2024

Repeating https://github.com/UoMResearchIT/RTP-215-Photon-Propagation-Issue-Only/issues/33 for the new forked repo:

  • Add code from previous Manchester fork to enable the photon emitter and (re)build from source
  • Test new code against results from previous fork
  • Test new code on HEP cluster
  • Write tests for photon emitter (in src/emitters/tests) but also add something testable to the MPhys/Single_Emitter directory - to be tracked in Write tests for single_emitter #4.
  • Rework branches to preserve history
@andrewgait andrewgait self-assigned this Oct 8, 2024
@ianhinder
Copy link

Andy will tweak the branch structure so that his original work on top of yangocean/mitsuba3-manchester's main branch is just pushed into this new uomresearchit/mitsuba3-manchester repository. This should show all the original history linked up correctly. 🤞

@ianhinder
Copy link

The tests are being tracked in #4.

@andrewgait
Copy link
Collaborator Author

Branches in UoMResearchIT/mitsuba3-manchester now tweaked so that commit history in yangocean-sudo/mitsuba3-manchester is preserved (into the main and then dev branches of the new fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants