Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade bdk library #98

Open
binarybaron opened this issue Sep 23, 2024 · 6 comments · May be fixed by #180
Open

Upgrade bdk library #98

binarybaron opened this issue Sep 23, 2024 · 6 comments · May be fixed by #180
Labels
crate: swap Related to the "swap" crate

Comments

@binarybaron
Copy link

binarybaron commented Sep 23, 2024

According to a core developer of the bdk library comit-network#1772 can probably be fixed by upgrading to the latest version of the crate. They added a bunch of improvements to the syncing logic.

@binarybaron binarybaron added the crate: swap Related to the "swap" crate label Sep 23, 2024
@binarybaron
Copy link
Author

This is currently blocked by bitcoindevkit/bdk#1606. We need a way to migrate the wallet data.

@binarybaron
Copy link
Author

Turns out the issue is not really blocking our migration. We can just switch to 1.0.0-alpha version of bdk. The descriptors and keys are derived from our seed. The first sync post-upgrade will take a while but all data currently stored in the sled wallet database can be derived from the blockchain state. We won't loose any data aside from caches.

@binarybaron binarybaron added the Bounty 💸 Whoever implements a PR to this issue received the bounty once the PR is merged label Oct 9, 2024
@binarybaron
Copy link
Author

binarybaron commented Oct 9, 2024

We use bounties to incentivize development and reward contributors. All issues available for a bounty have the Bounty 💸 label.

To receive the bounty of this issue, you agree to these conditions:

  • Your changes must follow the styling guidelines.
  • Bounties will be set and awarded at discretion of @binarybaron .
    The issues eligible for a bounty are labelled Bounty 💸 and have the amount of the bounty specified in the title in this form: [Bounty: 1 XMR].
  • An issue is considered resolved when the patch(es) proposed by the contributor is/are merged in the appropriate repository according to terms of the issue.
  • The first person who resolves an issue in its entirety will receive the entire amount of the bounty.
  • If the issue is resolved collaboratively by more than one person, the reward will be distributed among the contributors
  • Let the Maintainers know if you intend to work on a bounty, so that the issue can be assigned to you. Being assigned to an issue doesn't make that issue resolvable only by the assignee. It's meant to avoid duplication of efforts and not to discourage collective works.
  • After the issue is resolved, contact @binarybaron and claim your bounty (remember to provide them with a Monero address).
  • If required, we can also payout bounties via Bitcoin

@binarybaron binarybaron changed the title Upgrade bdk library [Bounty: 1 XMR] Upgrade bdk library Oct 9, 2024
@binarybaron binarybaron changed the title [Bounty: 1 XMR] Upgrade bdk library [Bounty💸 1 XMR] Upgrade bdk library Oct 9, 2024
@binarybaron binarybaron changed the title [Bounty💸 1 XMR] Upgrade bdk library [Bounty: 1 XMR] Upgrade bdk library Oct 9, 2024
@binarybaron
Copy link
Author

@binarybaron
Copy link
Author

@Einliterflasche You wanna take this on once we merge #109?

@Einliterflasche Einliterflasche changed the title [Bounty: 1 XMR] Upgrade bdk library Upgrade bdk library Nov 23, 2024
@Einliterflasche Einliterflasche removed the Bounty 💸 Whoever implements a PR to this issue received the bounty once the PR is merged label Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crate: swap Related to the "swap" crate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants