feat: view diff in change requests #8852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
kwasniew
requested review from
Tymek,
sjaanus,
FredrikOseberg and
thomasheartman
| @@ -69,6 +69,11 @@ const StyledContainer: FC<{ children?: React.ReactNode }> = styled('div')( | |||
| }), | |||
| ); | |||
|
|
|||
| const ViewDiff = styled('span')(({ theme }) => ({ | |||
There was a problem hiding this comment.
Should this be a button? I'm not sure I understand exactly how this works. Do you click "view diff" to open it? If so, it should definitely render as a button. Do you just hover it? If so, we should make sure you can tab to it correctly.
There was a problem hiding this comment.
It's hover based tooltip and it's tab friendly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Folks using change requests had problems discovering hover action on strategy type to get change request diff.
We make View Diff explicit
And this is on hover state
Important files
Discussion points