Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: flush metrics on clean shutdown #564

Merged
merged 2 commits into from
Oct 16, 2024
Merged

feat: flush metrics on clean shutdown #564

merged 2 commits into from
Oct 16, 2024

Conversation

sighphyre
Copy link
Member

@sighphyre sighphyre commented Oct 16, 2024 •
edited
Loading

Flushes metrics to upstream on shutdown. Needs a bit of love and/or discussion before merge:

  1. Be cool if this was tested by the same things that test the standard metrics send but I don't see those tests (currently tested by humans)
  2. Is 5 parameters to a function too much? It feels like too much

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 16, 2024 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@sighphyre sighphyre marked this pull request as ready for review October 16, 2024 08:30
chriswk
chriswk approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@chriswk chriswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sighphyre sighphyre merged commit acfb38b into main Oct 16, 2024
9 checks passed
@sighphyre sighphyre deleted the feat/shutdown-metrics-flush branch October 16, 2024 08:49
@sighphyre sighphyre mentioned this pull request Oct 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriswk chriswk chriswk approved these changes

Assignees

@sighphyre sighphyre

Labels
None yet
Projects
Issues and PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sighphyre @chriswk