Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task: remove request tracing #548

Merged
merged 1 commit into from
Oct 16, 2024
Merged

task: remove request tracing #548

merged 1 commit into from
Oct 16, 2024

Conversation

chriswk
Copy link
Member

@chriswk chriswk commented Oct 1, 2024

Originally we wanted to support OpenTelemetry for tracing, but we no longer support setting up an OTEL_COLLECTOR, so removing the request tracer seems sensible.

If we ever get around to adding an opentelemetry feature, this can be added back in.

@chriswk chriswk requested a review from sighphyre October 1, 2024 08:51
@chriswk chriswk self-assigned this Oct 1, 2024
Copy link

github-actions bot commented Oct 1, 2024

Dependency Review

The following issues were found:

  • ✅ 0 vulnerable package(s)
  • ❌ 1 package(s) with incompatible licenses
  • ❌ 2 package(s) with invalid SPDX license definitions
  • ⚠️ 1 package(s) with unknown licenses.

View full job summary

Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Originally we wanted to support OpenTelemetry for tracing, but we no
longer support setting up an OTEL_COLLECTOR, so removing the request
tracer seems sensible
@chriswk chriswk merged commit 32680a7 into main Oct 16, 2024
8 of 9 checks passed
@chriswk chriswk deleted the task/removeRequestTracing branch October 16, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants