Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom strategies that aren't configured into the client are hard to debug #51

Open
rbtcollins opened this issue Sep 27, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@rbtcollins
Copy link
Collaborator

Describe the bug

This log shows a test with a custom strategy that hasn't been enabled using .strategy(): it requires a TRACE level log statement to even tell that that is whats happened.

2022-09-27T20:12:34.518Z TRACE [unleash_api_client::client] memoize: start with 1 features
2022-09-27T20:12:34.518Z TRACE [unleash_api_client::client] memoize: swapped memoized state in
2022-09-27T20:12:34.518Z DEBUG [unleash_api_client::client] poll: waiting 500ms
2022-09-27T20:12:35.013Z TRACE [unleash_api_client::client] is_enabled: feature project_test default false, context Some(Context { user_id: None, session_id: None, remote_address: None, properties: {"projectId": "project", "cluster": "clustername"}, app_name: "app", environment: "clustername" })
2022-09-27T20:12:35.013Z TRACE [unleash_api_client::client] is_enabled: feature project_test default false, context Some(Context { user_id: None, session_id: None, remote_address: None, properties: {"projectId": "project", "cluster": "clustername"}, app_name: "app", environment: "clustername" })
2022-09-27T20:12:35.013Z TRACE [unleash_api_client::client] is_enabled: feature project_test has no strategies: enabling
feature 'project_test' is true

We should probably log the silent dropping of unknown strategies much more visibly.

Steps to reproduce the bug

No response

Expected behavior

No response

Logs, error output, etc.

No response

Screenshots

No response

Additional context

No response

Unleash version

No response

Subscription type

No response

Hosting type

No response

SDK information (language and version)

No response

@rbtcollins rbtcollins added the bug Something isn't working label Sep 27, 2022
@nunogois
Copy link
Member

nunogois commented Oct 3, 2022

Hi @rbtcollins - Thanks for opening this issue. I'll reach out to the rest of the team and we'll get back to you 👍

@nunogois nunogois moved this from New to Todo in Issues and PRs Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants