Update people -> person #332
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a few peoples are still left with people as the lemma there is even one people_NN which stayed people addresses UniversalDependencies/UD_English-GUM#53 which was actually an issue in EWT, not GUM
AngledLuffa
changed the title
|
One exception which I deliberately left undone was this one, although it might also qualify as "person" |
|
Oh right, will take a look soon |
nschneid
reviewed
Jul 23, 2022
| @@ -710,7 +710,7 @@ | |||
| # text = The American people were NOT having any of it, and elected Richard Nixon to fix the mess LBJ had made (not to surrender like the antiwar movement was demanding). | |||
| 1 The the DET DT Definite=Def|PronType=Art 3 det 3:det _ | |||
| 2 American American ADJ JJ Degree=Pos 3 amod 3:amod _ | |||
| 3 people people NOUN NNS Number=Plur 6 nsubj 6:nsubj|12:nsubj _ | |||
| 3 people person NOUN NNS Number=Plur 6 nsubj 6:nsubj|12:nsubj _ | |||
There was a problem hiding this comment.
Is this the nation sense of 'people'? You wouldn't say "the American individuals/persons"
There was a problem hiding this comment.
"the American and Canadian peoples"?
There was a problem hiding this comment.
I don't have a ton of stake in this one - if we want certain ones to be "people" instead of "person", happy to make that change. Is this the main one that sticks out to you, or was it more of a general change that needs to happen?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of people -> person in the lemmas
a few peoples are still left with people as the lemma
there is even one people_NN which stayed people
addresses
UniversalDependencies/UD_English-GUM#53
which was actually an issue in EWT, not GUM