Skip to content
This repository has been archived by the owner on Dec 19, 2024. It is now read-only.

Remove jupyter notebook dependency in datasetinsights PyPI package #163

Open
2 tasks
adason opened this issue Mar 25, 2021 · 0 comments
Open
2 tasks

Remove jupyter notebook dependency in datasetinsights PyPI package #163

adason opened this issue Mar 25, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@adason
Copy link
Contributor

adason commented Mar 25, 2021

Why you need this feature:
The current package includes jupyter notebooks which was for convenience but does not really properly install notebook dependencies when users try to do pip install datasetinsights. In fact, the datasetinsights package does not really need to make jupyter as dependencies.

Describe the solution you'd like:
In order to reduce confusion, I propose the following changes:

  • Remove jupyter notebook related dependencies for the datasetinsight package published to PyPI.
  • Add jupyter notebook dependencies in the docker environment ONLY.

Anything else you would like to add:
Related discussion can be found here

@adason adason added the enhancement New feature or request label Mar 25, 2021
@adason adason changed the title Remove jupyter notebook dependency in datasetinsights package Remove jupyter notebook dependency in datasetinsights PyPI package Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant