Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point/Station featureCollections don't use ncml #407

Open
tdrwenski opened this issue Jul 28, 2023 · 0 comments
Open

Point/Station featureCollections don't use ncml #407

tdrwenski opened this issue Jul 28, 2023 · 0 comments

Comments

@tdrwenski
Copy link
Contributor

tdrwenski commented Jul 28, 2023

Ncml in featureCollections is not used or tested. The issue is probably in the DatasetManager::openNetcdfFile and DatasetManager::openCoverageDataset. We should add integration tests for both cases, e.g. through WMS/ opendap and opening as a coverage through NCSS. Check that both metadata and data changes work with ncml (e.g. renaming a variable and applying an enhancement such as the Standardizer).

See the featureCollection documentation:

NcML is no longer used to define the collection, but it may still be used to modify the feature collection dataset for FMRC or Point (not GRIB).

I have manually tested featureType=FMRC, and that does seem to work with NcML. And the above says it should not work with GRIB1/GRIB2. Ncml does not seem to work with featureType=Point or featureType=station, so either that needs to be fixed or the documentation should be updated.

@tdrwenski tdrwenski changed the title featureCollections don't use ncml Point/Station featureCollections don't use ncml Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant