From b61dd5406854e7a5e8d03a444652558bc8fa18e7 Mon Sep 17 00:00:00 2001 From: Tara Drwenski Date: Wed, 10 Apr 2024 15:18:08 -0500 Subject: [PATCH 1/9] Do not use deprecated gradle configurations --- dap4/d4ts/build.gradle | 4 +- opendap/dtswar/build.gradle | 16 ++--- opendap/server/build.gradle | 6 +- tdcommon/build.gradle | 30 ++++---- tdm/build.gradle | 34 ++++----- tds-ugrid/build.gradle | 16 ++--- tds-ui/build.gradle | 8 +-- tds/build.gradle | 134 ++++++++++++++++++------------------ 8 files changed, 124 insertions(+), 124 deletions(-) diff --git a/dap4/d4ts/build.gradle b/dap4/d4ts/build.gradle index 7b02b113e3..b20cf3aaf3 100644 --- a/dap4/d4ts/build.gradle +++ b/dap4/d4ts/build.gradle @@ -12,8 +12,8 @@ dependencies { compileOnly 'org.slf4j:slf4j-api' - runtime 'org.apache.logging.log4j:log4j-slf4j-impl' - runtime 'org.apache.logging.log4j:log4j-web' + runtimeOnly 'org.apache.logging.log4j:log4j-slf4j-impl' + runtimeOnly 'org.apache.logging.log4j:log4j-web' compileOnly 'org.slf4j:slf4j-api' } diff --git a/opendap/dtswar/build.gradle b/opendap/dtswar/build.gradle index 4c8a399d81..a7e7f6e4c7 100644 --- a/opendap/dtswar/build.gradle +++ b/opendap/dtswar/build.gradle @@ -7,18 +7,18 @@ apply from: "$rootDir/gradle/any/war-published.gradle" dependencies { implementation enforcedPlatform(project(':tds-platform')) - compile project(':opendap:opendap-servlet') + implementation project(':opendap:opendap-servlet') - compile 'edu.ucar:cdm-core' - compile 'edu.ucar:opendap' - compile 'org.slf4j:slf4j-api' + implementation 'edu.ucar:cdm-core' + implementation 'edu.ucar:opendap' + implementation 'org.slf4j:slf4j-api' providedCompile "jakarta.servlet:jakarta.servlet-api:${depVersion.javaxServletApi}" - runtime 'org.apache.taglibs:taglibs-standard-spec' - runtime 'org.apache.taglibs:taglibs-standard-impl' + runtimeOnly 'org.apache.taglibs:taglibs-standard-spec' + runtimeOnly 'org.apache.taglibs:taglibs-standard-impl' - runtime 'org.apache.logging.log4j:log4j-slf4j-impl' - runtime 'org.apache.logging.log4j:log4j-web' + runtimeOnly 'org.apache.logging.log4j:log4j-slf4j-impl' + runtimeOnly 'org.apache.logging.log4j:log4j-web' } diff --git a/opendap/server/build.gradle b/opendap/server/build.gradle index f7ebe02d2c..ad588f0090 100644 --- a/opendap/server/build.gradle +++ b/opendap/server/build.gradle @@ -8,9 +8,9 @@ dependencies { implementation enforcedPlatform(project(':tds-platform')) testImplementation enforcedPlatform (project(':tds-testing-platform')) - compile 'edu.ucar:cdm-core' - compile 'edu.ucar:opendap' - compile 'org.slf4j:slf4j-api' + implementation 'edu.ucar:cdm-core' + implementation 'edu.ucar:opendap' + implementation 'org.slf4j:slf4j-api' compileOnly 'jakarta.servlet:jakarta.servlet-api' diff --git a/tdcommon/build.gradle b/tdcommon/build.gradle index e7d74ff39f..2d0e8eea65 100644 --- a/tdcommon/build.gradle +++ b/tdcommon/build.gradle @@ -8,26 +8,26 @@ apply from: "$rootDir/gradle/any/protobuf.gradle" dependencies { implementation enforcedPlatform(project(':tds-platform')) testImplementation enforcedPlatform (project(':tds-testing-platform')) - compile 'edu.ucar:cdm-core' - compile 'edu.ucar:cdm-s3' - compile 'edu.ucar:grib' - compile 'org.jdom:jdom2' + implementation 'edu.ucar:cdm-core' + implementation 'edu.ucar:cdm-s3' + implementation 'edu.ucar:grib' + implementation 'org.jdom:jdom2' - compile 'jakarta.validation:jakarta.validation-api' - compile 'jakarta.annotation:jakarta.annotation-api' + implementation 'jakarta.validation:jakarta.validation-api' + implementation 'jakarta.annotation:jakarta.annotation-api' - compile 'org.quartz-scheduler:quartz' - compile 'net.openhft:chronicle-map' - compile 'com.google.code.findbugs:jsr305' - compile 'com.google.guava:guava' - compile 'com.google.protobuf:protobuf-java' + implementation 'org.quartz-scheduler:quartz' + implementation 'net.openhft:chronicle-map' + implementation 'com.google.code.findbugs:jsr305' + implementation 'com.google.guava:guava' + implementation 'com.google.protobuf:protobuf-java' - compile 'org.slf4j:slf4j-api' + implementation 'org.slf4j:slf4j-api' // Spring - compile 'org.springframework:spring-core' - compile 'org.springframework:spring-context' - compile 'org.springframework:spring-beans' + implementation 'org.springframework:spring-core' + implementation 'org.springframework:spring-context' + implementation 'org.springframework:spring-beans' // Testing testImplementation 'edu.ucar:cdm-test-utils' // Contains stuff like the JUnit @Category classes. diff --git a/tdm/build.gradle b/tdm/build.gradle index 324744740e..786a116388 100644 --- a/tdm/build.gradle +++ b/tdm/build.gradle @@ -13,26 +13,26 @@ apply plugin: 'com.github.johnrengelman.shadow' dependencies { implementation enforcedPlatform(project(':tds-platform')) - compile project(':tdcommon') - compile 'edu.ucar:httpservices' - compile 'edu.ucar:cdm-core' - compile 'edu.ucar:grib' - - compile 'org.apache.httpcomponents:httpclient' - compile 'org.jdom:jdom2' - compile 'org.springframework:spring-beans' - compile 'org.springframework:spring-core' - compile 'org.springframework:spring-context' - compile 'com.google.protobuf:protobuf-java' - compile 'com.beust:jcommander' - compile 'com.google.guava:guava' - - compile 'org.slf4j:slf4j-api' - runtime 'org.apache.logging.log4j:log4j-slf4j-impl' + implementation project(':tdcommon') + implementation 'edu.ucar:httpservices' + implementation 'edu.ucar:cdm-core' + implementation 'edu.ucar:grib' + + implementation 'org.apache.httpcomponents:httpclient' + implementation 'org.jdom:jdom2' + implementation 'org.springframework:spring-beans' + implementation 'org.springframework:spring-core' + implementation 'org.springframework:spring-context' + implementation 'com.google.protobuf:protobuf-java' + implementation 'com.beust:jcommander' + implementation 'com.google.guava:guava' + + implementation 'org.slf4j:slf4j-api' + implementation 'org.apache.logging.log4j:log4j-slf4j-impl' } shadowJar { - baseName = 'tdmFat' + archiveBaseName = 'tdmFat' setArchiveBaseName('tdmFat') classifier '' setArchiveClassifier '' diff --git a/tds-ugrid/build.gradle b/tds-ugrid/build.gradle index e821434aac..fd83a39611 100644 --- a/tds-ugrid/build.gradle +++ b/tds-ugrid/build.gradle @@ -9,18 +9,18 @@ apply from: "$rootDir/gradle/any/java-published.gradle" dependencies { implementation enforcedPlatform (project(':tds-platform')) - testCompile enforcedPlatform (project(':tds-testing-platform')) + testImplementation enforcedPlatform (project(':tds-testing-platform')) - compile 'edu.ucar:cdm-core' - compile 'edu.ucar:cdm-s3' + implementation 'edu.ucar:cdm-core' + implementation 'edu.ucar:cdm-s3' implementation 'colt:colt:1.2.0' // Testing - testCompile project(':tds-test-utils'); - testCompile 'edu.ucar:cdm-test-utils' // Contains stuff like the JUnit @Category classes. - testCompile 'junit:junit' - testCompile 'com.google.truth:truth' + testImplementation project(':tds-test-utils'); + testImplementation 'edu.ucar:cdm-test-utils' // Contains stuff like the JUnit @Category classes. + testImplementation 'junit:junit' + testImplementation 'com.google.truth:truth' // Logging - compile 'org.slf4j:slf4j-api' + implementation 'org.slf4j:slf4j-api' } diff --git a/tds-ui/build.gradle b/tds-ui/build.gradle index ec26ca56e0..a8aa2577e4 100644 --- a/tds-ui/build.gradle +++ b/tds-ui/build.gradle @@ -9,11 +9,11 @@ apply plugin: 'application' dependencies { implementation enforcedPlatform(project(':tds-platform')) - testCompile enforcedPlatform(project(':tds-testing-platform')) + testImplementation enforcedPlatform(project(':tds-testing-platform')) - runtime 'edu.ucar:uicdm' - runtime 'edu.ucar:cdm-s3' - runtime project(':tds-ugrid') + runtimeOnly 'edu.ucar:uicdm' + runtimeOnly 'edu.ucar:cdm-s3' + runtimeOnly project(':tds-ugrid') } application { diff --git a/tds/build.gradle b/tds/build.gradle index daf3aba123..aa8857a9aa 100644 --- a/tds/build.gradle +++ b/tds/build.gradle @@ -11,23 +11,23 @@ apply from: "$rootDir/gradle/any/gretty.gradle" dependencies { implementation enforcedPlatform (project(':tds-platform')) - testCompile enforcedPlatform (project(':tds-testing-platform')) - - compile 'edu.ucar:bufr' - compile 'edu.ucar:cdm-core' - compile 'edu.ucar:cdm-radial' - compile 'edu.ucar:cdm-misc' - compile 'edu.ucar:cdm-image' - compile 'edu.ucar:cdm-s3' - compile 'edu.ucar:cdm-zarr' - compile 'edu.ucar:grib' - compile 'edu.ucar:netcdf4' - compile 'edu.ucar:httpservices' - compile 'edu.ucar:opendap' - compile project(':opendap:opendap-servlet') - compile project(':tdcommon') - compile 'edu.ucar:cdm-mcidas' - compile 'edu.ucar:waterml' + testImplementation enforcedPlatform (project(':tds-testing-platform')) + + implementation 'edu.ucar:bufr' + implementation 'edu.ucar:cdm-core' + implementation 'edu.ucar:cdm-radial' + implementation 'edu.ucar:cdm-misc' + implementation 'edu.ucar:cdm-image' + implementation 'edu.ucar:cdm-s3' + implementation 'edu.ucar:cdm-zarr' + implementation 'edu.ucar:grib' + implementation 'edu.ucar:netcdf4' + implementation 'edu.ucar:httpservices' + implementation 'edu.ucar:opendap' + implementation project(':opendap:opendap-servlet') + implementation project(':tdcommon') + implementation 'edu.ucar:cdm-mcidas' + implementation 'edu.ucar:waterml' implementation project(':tds-ugrid') // DAP4 Dependencies (technically forward) @@ -36,85 +36,85 @@ dependencies { // Server stuff providedCompile "jakarta.servlet:jakarta.servlet-api:${depVersion.javaxServletApi}" - runtime 'org.apache.taglibs:taglibs-standard-spec' - runtime 'org.apache.taglibs:taglibs-standard-impl' + runtimeOnly 'org.apache.taglibs:taglibs-standard-spec' + runtimeOnly 'org.apache.taglibs:taglibs-standard-impl' // Apache httpclient libraries - compile 'org.apache.httpcomponents:httpclient' - compile 'org.apache.httpcomponents:httpcore' + implementation 'org.apache.httpcomponents:httpclient' + implementation 'org.apache.httpcomponents:httpcore' - compile 'com.coverity.security:coverity-escapers' // todo: replace with google escapers? - compile 'org.jdom:jdom2' - compile 'org.quartz-scheduler:quartz' - compile 'com.google.code.findbugs:jsr305' - compile 'com.google.guava:guava' - compile 'joda-time:joda-time' - compile 'org.apache.commons:commons-lang3' + implementation 'com.coverity.security:coverity-escapers' // todo: replace with google escapers? + implementation 'org.jdom:jdom2' + implementation 'org.quartz-scheduler:quartz' + implementation 'com.google.code.findbugs:jsr305' + implementation 'com.google.guava:guava' + implementation 'joda-time:joda-time' + implementation 'org.apache.commons:commons-lang3' // WaterML - compile 'org.apache.xmlbeans:xmlbeans' - compile 'org.n52.sensorweb:52n-xml-waterML-v20' - compile 'org.n52.sensorweb:52n-xml-om-v20' + implementation 'org.apache.xmlbeans:xmlbeans' + implementation 'org.n52.sensorweb:52n-xml-waterML-v20' + implementation 'org.n52.sensorweb:52n-xml-om-v20' // Spring - compile 'org.springframework:spring-core' - compile 'org.springframework:spring-context' - compile 'org.springframework:spring-beans' - compile 'org.springframework:spring-web' - compile 'org.springframework:spring-webmvc' - runtime 'org.springframework.security:spring-security-web' // Needed for FilterChainProxy in applicationContext.xml. - runtime 'org.springframework.security:spring-security-config' // Needed for "xmlns:security" schema in applicationContext.xml. + implementation 'org.springframework:spring-core' + implementation 'org.springframework:spring-context' + implementation 'org.springframework:spring-beans' + implementation 'org.springframework:spring-web' + implementation 'org.springframework:spring-webmvc' + runtimeOnly 'org.springframework.security:spring-security-web' // Needed for FilterChainProxy in applicationContext.xml. + runtimeOnly 'org.springframework.security:spring-security-config' // Needed for "xmlns:security" schema in applicationContext.xml. // Needed for XPath operations in mock tests - testCompile 'jaxen:jaxen' + testImplementation 'jaxen:jaxen' // Needed for XPaths in WmsDetailedConfig - runtime 'jaxen:jaxen' + runtimeOnly 'jaxen:jaxen' // edal ncwms related libs - compile('uk.ac.rdg.resc:edal-common') - compile ('uk.ac.rdg.resc:edal-cdm') - compile ('uk.ac.rdg.resc:edal-graphics') - compile ('uk.ac.rdg.resc:edal-wms') - compile('uk.ac.rdg.resc:edal-godiva') + implementation('uk.ac.rdg.resc:edal-common') + implementation ('uk.ac.rdg.resc:edal-cdm') + implementation ('uk.ac.rdg.resc:edal-graphics') + implementation ('uk.ac.rdg.resc:edal-wms') + implementation('uk.ac.rdg.resc:edal-godiva') // json writing 'org.json:json' // JSR 303 with Hibernate Validator, which is dragging in jboss logging - runtime 'org.hibernate.validator:hibernate-validator' - runtime 'org.glassfish:javax.el' + runtimeOnly 'org.hibernate.validator:hibernate-validator' + runtimeOnly 'org.glassfish:javax.el' annotationProcessor "org.hibernate.validator:hibernate-validator-annotation-processor:${depVersion.hibernateValidator}" // @Resource annotation (removed post Java 8) - compile 'jakarta.annotation:jakarta.annotation-api' + implementation 'jakarta.annotation:jakarta.annotation-api' - compile 'org.thymeleaf:thymeleaf-spring5' + implementation 'org.thymeleaf:thymeleaf-spring5' // Testing - testCompile "jakarta.servlet:jakarta.servlet-api:${depVersion.javaxServletApi}" - testCompile 'org.springframework:spring-test' - testCompile 'org.hamcrest:hamcrest-core' - testCompile 'commons-io:commons-io' - testCompile 'pl.pragmatists:JUnitParams' - testCompile 'com.google.truth:truth' - testCompile 'junit:junit' - testCompile project(':tds-test-utils'); - testCompile 'edu.ucar:cdm-test-utils' // Contains stuff like the JUnit @Category classes. - testCompile 'edu.ucar:httpservices' + testImplementation "jakarta.servlet:jakarta.servlet-api:${depVersion.javaxServletApi}" + testImplementation 'org.springframework:spring-test' + testImplementation 'org.hamcrest:hamcrest-core' + testImplementation 'commons-io:commons-io' + testImplementation 'pl.pragmatists:JUnitParams' + testImplementation 'com.google.truth:truth' + testImplementation 'junit:junit' + testImplementation project(':tds-test-utils'); + testImplementation 'edu.ucar:cdm-test-utils' // Contains stuff like the JUnit @Category classes. + testImplementation 'edu.ucar:httpservices' // Logging - compile 'org.slf4j:slf4j-api' - runtime 'org.apache.logging.log4j:log4j-slf4j-impl' - runtime 'org.apache.logging.log4j:log4j-web' - testRuntime 'ch.qos.logback:logback-classic' + implementation 'org.slf4j:slf4j-api' + runtimeOnly 'org.apache.logging.log4j:log4j-slf4j-impl' + runtimeOnly 'org.apache.logging.log4j:log4j-web' + testRuntimeOnly 'ch.qos.logback:logback-classic' // This is for freshInstallTest - testCompile 'org.xmlunit:xmlunit-core' // For comparing catalog XML. + testImplementation 'org.xmlunit:xmlunit-core' // For comparing catalog XML. } // "testRuntime" extends from "runtime", meaning that "testRuntime" will get the log4j dependencies declared in // "runtime". However, we want logback-classic to be the logger during tests, so exclude all of the log4j stuff. -configurations.testRuntime { +configurations.testRuntimeOnly { exclude group: 'org.apache.logging.log4j' } @@ -271,8 +271,8 @@ testInfomation.forEach { testInfo -> resources.srcDir file("src/${testInfo.name}/resources") // Need 'sourceSets.test.output' because we use TestOnLocalServer in our test. - compileClasspath += sourceSets.test.output + configurations.testCompile - runtimeClasspath += output + sourceSets.test.output + configurations.testRuntime + compileClasspath += sourceSets.test.output + configurations.testCompileClasspath + runtimeClasspath += output + sourceSets.test.output + configurations.testRuntimeClasspath } def thisTestTask = tasks.create("${testInfo.name}", Test) { From 8ccdc484ebc1689d4e12d1ae2e9fb68b60c59ced Mon Sep 17 00:00:00 2001 From: Tara Drwenski Date: Tue, 16 Apr 2024 16:31:50 +0200 Subject: [PATCH 2/9] Update gradle to version 7 --- gradle/wrapper/gradle-wrapper.properties | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gradle/wrapper/gradle-wrapper.properties b/gradle/wrapper/gradle-wrapper.properties index c19e35bf78..3c4101c3ec 100644 --- a/gradle/wrapper/gradle-wrapper.properties +++ b/gradle/wrapper/gradle-wrapper.properties @@ -1,5 +1,5 @@ distributionBase=GRADLE_USER_HOME distributionPath=wrapper/dists -distributionUrl=https\://services.gradle.org/distributions/gradle-6.9.1-all.zip +distributionUrl=https\://services.gradle.org/distributions/gradle-7.0-all.zip zipStoreBase=GRADLE_USER_HOME zipStorePath=wrapper/dists From 1f38536f3eed01073bd330b1d1fe54f2ae5a946e Mon Sep 17 00:00:00 2001 From: Tara Drwenski Date: Tue, 16 Apr 2024 16:32:06 +0200 Subject: [PATCH 3/9] Update the shadow plugin to work with gradle 7 --- gradle/any/shared-mvn-coords.gradle | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gradle/any/shared-mvn-coords.gradle b/gradle/any/shared-mvn-coords.gradle index 2f539646a9..70047bc50e 100644 --- a/gradle/any/shared-mvn-coords.gradle +++ b/gradle/any/shared-mvn-coords.gradle @@ -6,7 +6,7 @@ ext { // plugin version management buildPlugins = [:] buildPlugins.gretty = 'org.gretty:gretty:3.0.9' - buildPlugins.shadow = 'com.github.jengelman.gradle.plugins:shadow:5.2.0' + buildPlugins.shadow = 'gradle.plugin.com.github.johnrengelman:shadow:7.1.2' buildPlugins.sonarqube = 'org.sonarsource.scanner.gradle:sonarqube-gradle-plugin:3.0' buildPlugins.spotless = 'com.diffplug.spotless:spotless-plugin-gradle:4.5.1' buildPlugins.protobuf = 'com.google.protobuf:protobuf-gradle-plugin:0.8.18' From 022b7a7876c8f5ed3c58848239e4347c4b88202c Mon Sep 17 00:00:00 2001 From: Tara Drwenski Date: Tue, 16 Apr 2024 16:51:41 +0200 Subject: [PATCH 4/9] Add back dependencies needed to compile --- tds/build.gradle | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tds/build.gradle b/tds/build.gradle index aa8857a9aa..29527d5c07 100644 --- a/tds/build.gradle +++ b/tds/build.gradle @@ -30,6 +30,9 @@ dependencies { implementation 'edu.ucar:waterml' implementation project(':tds-ugrid') + implementation 'net.openhft:chronicle-map' + implementation 'jakarta.validation:jakarta.validation-api' + // DAP4 Dependencies (technically forward) implementation 'edu.ucar:dap4' implementation project(':dap4:d4servlet') From 4cc1715e08f94c40b629bf0d2f3c4cbacc9f2f1c Mon Sep 17 00:00:00 2001 From: Tara Drwenski Date: Wed, 17 Apr 2024 10:57:42 +0200 Subject: [PATCH 5/9] Update gradle to 7.6.4 --- build.gradle | 2 +- gradle/wrapper/gradle-wrapper.properties | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/build.gradle b/build.gradle index e81d914fc6..c5a45d411e 100644 --- a/build.gradle +++ b/build.gradle @@ -101,7 +101,7 @@ ext { tasks.named('wrapper') { distributionType = Wrapper.DistributionType.ALL - gradleVersion = '6.9.1' + gradleVersion = '7.6.4' } gradle.projectsEvaluated { diff --git a/gradle/wrapper/gradle-wrapper.properties b/gradle/wrapper/gradle-wrapper.properties index 3c4101c3ec..763217c50f 100644 --- a/gradle/wrapper/gradle-wrapper.properties +++ b/gradle/wrapper/gradle-wrapper.properties @@ -1,5 +1,5 @@ distributionBase=GRADLE_USER_HOME distributionPath=wrapper/dists -distributionUrl=https\://services.gradle.org/distributions/gradle-7.0-all.zip +distributionUrl=https\://services.gradle.org/distributions/gradle-7.6.4-all.zip zipStoreBase=GRADLE_USER_HOME zipStorePath=wrapper/dists From 9af78357aebdb8d359d52efc53c3d7d46112b8e2 Mon Sep 17 00:00:00 2001 From: Tara Drwenski Date: Wed, 17 Apr 2024 11:59:20 +0200 Subject: [PATCH 6/9] Remove archiveBaseName and archiveClassifier as these are overridden by archiveFileName anyhow --- tdm/build.gradle | 4 ---- 1 file changed, 4 deletions(-) diff --git a/tdm/build.gradle b/tdm/build.gradle index 786a116388..bd04f91f13 100644 --- a/tdm/build.gradle +++ b/tdm/build.gradle @@ -32,10 +32,6 @@ dependencies { } shadowJar { - archiveBaseName = 'tdmFat' - setArchiveBaseName('tdmFat') - classifier '' - setArchiveClassifier '' doFirst { manifest.attributes jar.manifest.attributes } From f2530d2bdca4232261179c1979228d36d3ef9b46 Mon Sep 17 00:00:00 2001 From: Tara Drwenski Date: Wed, 17 Apr 2024 12:41:25 +0200 Subject: [PATCH 7/9] Fix implicit dependency gradle warning --- tdcommon/build.gradle | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tdcommon/build.gradle b/tdcommon/build.gradle index 2d0e8eea65..fded47a08e 100644 --- a/tdcommon/build.gradle +++ b/tdcommon/build.gradle @@ -43,3 +43,7 @@ spotless { targetExclude('src/main/java/thredds/server/catalog/tracker/ConfigCatalogExtProto.java') } } + +tasks.named('sourceJar').configure { + dependsOn('generateProto') +} From 1a6418b34633541c986ed61ae2d53a66493252b7 Mon Sep 17 00:00:00 2001 From: Tara Drwenski Date: Thu, 18 Apr 2024 17:07:10 +0200 Subject: [PATCH 8/9] Fix gradle duplicate resource issue --- tds/build.gradle | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tds/build.gradle b/tds/build.gradle index 29527d5c07..80b533a169 100644 --- a/tds/build.gradle +++ b/tds/build.gradle @@ -271,7 +271,7 @@ def previousTestTaskFinalizer = null testInfomation.forEach { testInfo -> sourceSets.create(testInfo.name) { - resources.srcDir file("src/${testInfo.name}/resources") + resources.srcDirs = [file("src/${testInfo.name}/resources")] // Need 'sourceSets.test.output' because we use TestOnLocalServer in our test. compileClasspath += sourceSets.test.output + configurations.testCompileClasspath From 3693a95d771c9ba0daf6cd69680382be1d50361f Mon Sep 17 00:00:00 2001 From: Tara Drwenski Date: Fri, 19 Apr 2024 13:45:38 +0200 Subject: [PATCH 9/9] Add back dependencies needed to compile --- opendap/dtswar/build.gradle | 1 + opendap/server/build.gradle | 1 + tdcommon/build.gradle | 1 + tdm/build.gradle | 1 + tds-ugrid/build.gradle | 1 + tds/build.gradle | 1 + 6 files changed, 6 insertions(+) diff --git a/opendap/dtswar/build.gradle b/opendap/dtswar/build.gradle index a7e7f6e4c7..9abbafd6f3 100644 --- a/opendap/dtswar/build.gradle +++ b/opendap/dtswar/build.gradle @@ -11,6 +11,7 @@ dependencies { implementation 'edu.ucar:cdm-core' implementation 'edu.ucar:opendap' + implementation 'org.jdom:jdom2' implementation 'org.slf4j:slf4j-api' providedCompile "jakarta.servlet:jakarta.servlet-api:${depVersion.javaxServletApi}" diff --git a/opendap/server/build.gradle b/opendap/server/build.gradle index ad588f0090..d5c317c13f 100644 --- a/opendap/server/build.gradle +++ b/opendap/server/build.gradle @@ -10,6 +10,7 @@ dependencies { implementation 'edu.ucar:cdm-core' implementation 'edu.ucar:opendap' + implementation 'org.jdom:jdom2' implementation 'org.slf4j:slf4j-api' compileOnly 'jakarta.servlet:jakarta.servlet-api' diff --git a/tdcommon/build.gradle b/tdcommon/build.gradle index fded47a08e..d73d713a8c 100644 --- a/tdcommon/build.gradle +++ b/tdcommon/build.gradle @@ -21,6 +21,7 @@ dependencies { implementation 'com.google.code.findbugs:jsr305' implementation 'com.google.guava:guava' implementation 'com.google.protobuf:protobuf-java' + implementation 'com.google.re2j:re2j' implementation 'org.slf4j:slf4j-api' diff --git a/tdm/build.gradle b/tdm/build.gradle index bd04f91f13..5fd8fb71f6 100644 --- a/tdm/build.gradle +++ b/tdm/build.gradle @@ -26,6 +26,7 @@ dependencies { implementation 'com.google.protobuf:protobuf-java' implementation 'com.beust:jcommander' implementation 'com.google.guava:guava' + implementation 'com.google.re2j:re2j' implementation 'org.slf4j:slf4j-api' implementation 'org.apache.logging.log4j:log4j-slf4j-impl' diff --git a/tds-ugrid/build.gradle b/tds-ugrid/build.gradle index fd83a39611..0a4dd6f790 100644 --- a/tds-ugrid/build.gradle +++ b/tds-ugrid/build.gradle @@ -14,6 +14,7 @@ dependencies { implementation 'edu.ucar:cdm-core' implementation 'edu.ucar:cdm-s3' implementation 'colt:colt:1.2.0' + implementation 'com.google.guava:guava' // Testing testImplementation project(':tds-test-utils'); diff --git a/tds/build.gradle b/tds/build.gradle index 80b533a169..75f25ce947 100644 --- a/tds/build.gradle +++ b/tds/build.gradle @@ -104,6 +104,7 @@ dependencies { testImplementation project(':tds-test-utils'); testImplementation 'edu.ucar:cdm-test-utils' // Contains stuff like the JUnit @Category classes. testImplementation 'edu.ucar:httpservices' + testImplementation 'com.beust:jcommander' // Logging implementation 'org.slf4j:slf4j-api'