From bef8cf0460e692115d3d0b6bbaa7b089721730a4 Mon Sep 17 00:00:00 2001 From: Dennis Heimbigner Date: Wed, 25 Oct 2023 15:14:29 -0600 Subject: [PATCH 1/2] Reduce warning by changing type of NC_OBJ.id. re: https://github.com/Unidata/netcdf-c/issues/2780 As noted in the above issue, changing the NC_OBJ.id field type from size_t to int reduces irrelevant warning. There is no semantic effect since the number of distinct ids will never approach the max positive integer value. Note that this could change in the future if the id becomes more than a simple counter. --- RELEASE_NOTES.md | 1 + include/nc4internal.h | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index 50c0ea53b5..ba82c156e4 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -7,6 +7,7 @@ This file contains a high-level description of this package's evolution. Release ## 4.9.3 - TBD +* Obviate a number of irrelevant warning. See [Github #????](https://github.com/Unidata/netcdf-c/pull/????). * Mitigate the problem of remote/nczarr-related test interference. See [Github #2755](https://github.com/Unidata/netcdf-c/pull/2755). * Extend NCZarr to support unlimited dimensions. See [Github #2755](https://github.com/Unidata/netcdf-c/pull/2755). * Fix significant bug in the NCZarr cache management. See [Github #2737](https://github.com/Unidata/netcdf-c/pull/2737). diff --git a/include/nc4internal.h b/include/nc4internal.h index f9925b1dea..9182c69800 100644 --- a/include/nc4internal.h +++ b/include/nc4internal.h @@ -131,7 +131,7 @@ typedef struct NC_OBJ { NC_SORT sort; /**< Type of object. */ char* name; /**< Name, assumed to be null terminated. */ - size_t id; /**< This objects ID. */ + int id; /**< This objects ID. */ } NC_OBJ; /** From 9df7f8d14b2b8d408887a51ce44dd674dd767f98 Mon Sep 17 00:00:00 2001 From: Dennis Heimbigner Date: Wed, 25 Oct 2023 15:26:46 -0600 Subject: [PATCH 2/2] Update release notes --- RELEASE_NOTES.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index ba82c156e4..1cebf9766a 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -7,7 +7,7 @@ This file contains a high-level description of this package's evolution. Release ## 4.9.3 - TBD -* Obviate a number of irrelevant warning. See [Github #????](https://github.com/Unidata/netcdf-c/pull/????). +* Obviate a number of irrelevant warnings. See [Github #2781](https://github.com/Unidata/netcdf-c/pull/2781). * Mitigate the problem of remote/nczarr-related test interference. See [Github #2755](https://github.com/Unidata/netcdf-c/pull/2755). * Extend NCZarr to support unlimited dimensions. See [Github #2755](https://github.com/Unidata/netcdf-c/pull/2755). * Fix significant bug in the NCZarr cache management. See [Github #2737](https://github.com/Unidata/netcdf-c/pull/2737).