Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add id macro DNA-12353 (DNA-19240) #69

Merged
merged 4 commits into from
Oct 5, 2023

Conversation

JasperSelmanUiPath
Copy link
Contributor

Description

  • add id macro for the new ID generation functionality.
  • deprecate generate_id macro, used in post-hooks.

Release

  • Direct release (main)
  • Merge to dev (or other) branch
    • Why:

Did you consider?

  • Does it Work on Automation Suite / SQL Server
  • Does it Work on Automation Cloud / Snowflake
  • What is the performance impact?
    • It is faster!
  • The version number in dbt_project.yml

@JasperSelmanUiPath JasperSelmanUiPath self-assigned this Oct 4, 2023
@silviustanimir silviustanimir self-requested a review October 4, 2023 11:21
Copy link
Contributor

@silviustanimir silviustanimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose we deprecate the generate_id macro in this version and then remove it when we enable Databricks and go for 1.0.0?

@JasperSelmanUiPath
Copy link
Contributor Author

I suppose we deprecate the generate_id macro in this version and then remove it when we enable Databricks and go for 1.0.0?

Missed the comment. Yes, since this release will not be a major release we need to guarantee backwards compatibility.

@JasperSelmanUiPath JasperSelmanUiPath merged commit 1d60251 into main Oct 5, 2023
2 checks passed
@JasperSelmanUiPath JasperSelmanUiPath deleted the feat/generate_id branch October 5, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants