You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 28, 2022. It is now read-only.
We should switch to including SWMM and EPANET engines in the UI project as submodules. This should help simplify the process of merging new engine versions with the UI.
@michaeltryby for running the simulation, we are already calling the DLL (which is a BIG module, technically speaking). So, we will need to think about what type of capability we would like to offer users by tapping directly into the inners of these models. Saving the entire state of the model inside the C modules is also likely, perhaps a bit unwieldy...
Sorry @TongZhai I was not very clear. I'm only talking about changing repo organization. Read up on git submodules command and I think you will understand what I am suggesting here.
@michaeltryby I don't see why not. So perhaps you can start by creating a new repository for the engines and we will go from there to setup the submodules inside this project.
@TongZhai Yes and no. I have existing repos for engines here and here. Submodules would allow us to include them directly in this project. There is no need to create new repos.
There is a way to create a folder within this repo that is a submodule linked back to the engine repo. I will read up on it over the weekend.
We should switch to including SWMM and EPANET engines in the UI project as submodules. This should help simplify the process of merging new engine versions with the UI.
@TongZhai any thoughts?
The text was updated successfully, but these errors were encountered: