Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added two pass-through functions for ENopen and ENclose #12

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

dbhart
Copy link
Contributor

@dbhart dbhart commented Mar 13, 2024

When using the toolkit through python, I was not able to get the MSX DLL to open the EPANET network (ENopen). I added two pass-through functions, MSXENopen and MSXENclose which are exported as part of the MSX DLL, since ctypes wasn't seeing the related EPANET DLL, even though it (seemingly) should have. These two minor additions allow the network to be opened using the toolkit, and then all the MSX functions work correctly.

Copy link
Collaborator

@cbuahin cbuahin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked for a way to load the EPANET dependency alongside MSX but it does not seem very straightforward. You solution looks good to me.

@cbuahin cbuahin merged commit ebabedf into USEPA:master Mar 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants