Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown IMP_DEF when called from gtirb-semantics #85

Closed
l-kent opened this issue Jun 12, 2024 · 5 comments · Fixed by #86
Closed

Unknown IMP_DEF when called from gtirb-semantics #85

l-kent opened this issue Jun 12, 2024 · 5 comments · Fixed by #86

Comments

@l-kent
Copy link

l-kent commented Jun 12, 2024

I get the following error when I attempt to lift a .gtirb file disassembled from a binary containing an LDAXR instruction (with opcode 0xc85ffd68 here).

error during aslp disassembly (opcode 0xc85ffd68, bytes 68FD5FC8):

Fatal error: exception LibASL.Value.EvalError("Unknown value for IMPLEMENTATION_DEFINED "Has Nested Virtualization"") at file "/nix/store/m146ac8nkl5y01wp2rgrd4iryf8grkw9-ocaml4.14.1-asli-unstable-2024-05-08/share/asli/aslfiles/mra_tools/arch/arch.asl" line 2651 char 11 - line 2652 char 0
Raised at LibASL__Eval.Env.getImpdef in file "libASL/eval.ml", line 447, characters 16-93
Called from LibASL__Dis.dis_expr'.(fun) in file "libASL/dis.ml", line 881, characters 41-71
Called from LibASL__Rws.RWSBase.reads in file "libASL/rws.ml", line 69, characters 47-50
Called from LibASL__Dis.let+ in file "libASL/dis.ml", line 456, characters 16-23
[...]
Called from LibASL__Dis.dis_decode_entry in file "libASL/dis.ml", line 1487, characters 27-67
Called from Dune__exe__Main.to_asli.do_dis in file "bin/main.ml", line 182, characters 13-75

This is notably different to the error when attempting to lift this instruction inside ASLp: #84

@l-kent
Copy link
Author

l-kent commented Jun 12, 2024

I think there are likely to be issues with stlxr too

@katrinafyi katrinafyi transferred this issue from UQ-PAC/gtirb-semantics Jun 12, 2024
@katrinafyi
Copy link
Member

Moved to aslp issue tracker as it's an issue with the interface aslp provides to gtirb-semantics.

Thanks to the different failure modes, I have a good guess as to the cause. Will get to this next week.

@katrinafyi katrinafyi changed the title LDAXR instruction error Unknown IMP_DEF when called from gtirb-semantics Jun 18, 2024
@katrinafyi
Copy link
Member

Do you have a .gtirb file which raises this error?

@l-kent
Copy link
Author

l-kent commented Jun 18, 2024

ldaxr.zip

@katrinafyi
Copy link
Member

The linked PR will bring this in line with #84 which is.. a more difficult problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants