Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial impression, great work! #18

Open
lcolladotor opened this issue Mar 30, 2016 · 3 comments
Open

Initial impression, great work! #18

lcolladotor opened this issue Mar 30, 2016 · 3 comments

Comments

@lcolladotor
Copy link

Hi,

I just looked at debrowser and I think that it's a great idea. It could be specially useful for teaching how to do RNA-seq data analysis without teaching R commands or for researchers that want to explore their DE results.

I found a list of technical issues or things I believe could be improved, see:

I submitted them as independent issues so it'll be easier for you to track/address them.

Also note that you use DESeq in several parts of the app and the documentation when you really mean DESeq2. These are different packages so I would just encourage you to be crystal clear.

Thinking on the long run, you might want to explore using https://github.com/aoles/DEFormats (cc'ing @aoles) if you want to support multiple differential expression packages.

Overall, this is great work and I know that you just submitted your package to Bioc. I hope to see debrowser at Bioconductor for a long time.

Best,
Leo

Leonardo Collado Torres, PhD Candidate
Department of Biostatistics
Johns Hopkins University
Bloomberg School of Public Health
Website: http://lcolladotor.github.io/about.html

@nephantes
Copy link
Member

Thanks Leonardo,
I will be addressing your comments pretty soon in the new version.

@lcolladotor
Copy link
Author

Congrats on the pre-print!

https://twitter.com/fellgernon/status/1034179967821725696

@nephantes
Copy link
Member

nephantes commented Aug 28, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants