Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colm/add footer #58

Merged
merged 7 commits into from
Feb 25, 2023
Merged

Colm/add footer #58

merged 7 commits into from
Feb 25, 2023

Conversation

colmmurphyxyz
Copy link
Member

No description provided.

@gal gal linked an issue Feb 4, 2023 that may be closed by this pull request
@gal gal self-requested a review February 4, 2023 16:40
Copy link
Member

@gal gal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but maybe change the footer size by decreasing the height of the discord iframe, and reducing the size of all icons and the Netsoc logo. Also maybe play around with box-sizing: border-box; with padding, just to add some whitespace around and below.

Apart from that, lgtm!

@gal gal self-requested a review February 25, 2023 16:42
Copy link
Member

@gal gal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@gal gal merged commit 0fd7527 into dev Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Footer
2 participants