Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last Klipper update #1

Closed
yet-another-average-joe opened this issue Jun 12, 2024 · 7 comments
Closed

Last Klipper update #1

yet-another-average-joe opened this issue Jun 12, 2024 · 7 comments

Comments

@yet-another-average-joe

I've been using KnobProbe_Klipper for 18 months as a auto Z offset endstop, after a few trivial modifications. With : BLTouch, BQ Microprobe, and a couple of DIY Klicky's. Worked flawlessly.
Until the last Klipper update...
The probe "extra" was refactored, and killed KnobProbe_Klipper.
Attempted to "repair" it, but miserably failed.

Are you considering an update in the future ?

@TypQxQ
Copy link
Owner

TypQxQ commented Jun 12, 2024 via email

@yet-another-average-joe
Copy link
Author

yet-another-average-joe commented Jun 12, 2024

Thanks for your answer !
Not much info.
Last known good Klipper is v0.12.0-207 / g6cd17420 (I rolled back !)

Access to probe attributes was changed.
Also, there's something with the multi probe begin and multi probe end procedures.
I'm not fluent with Python, and even less with the Klipper object model, unfortuanately... Had a hard time customizing KnobProbe !

Maybe this could be interesting : https://github.com/protoloft/klipper_z_calibration
It was updated very quickly, and could contain some usefull information

protoloft/klipper_z_calibration@4115614

I searched for other "extra" probes, but found nothing usefull (for now...) .

On Klipper forum (it doesn't really help) :

https://klipper.discourse.group/t/printerprobe-error-after-commit-d4bae4d/16967/3

The Beacon probe was quicly updated too (but looks unrelated) :

beacon3d/beacon_klipper@61266a4

Other "extra", that was not updated (but could be soon ?), and I never tested :

https://github.com/hawkeyexp/auto_offset_z

The last one ; not a probe, but accesses it : Dockable Probe by CloakedCode and Mental (seems to me CloakedCode is active on Discord/Armchair Heavy Industry / Danger-Klipper, but not sure). Played a bit with this plugin, before I discovered yours and gave up with Klicky's and magnets falling apart. There was a PR on Klipper Git, but it was never merged. Maybe he will update it ?

Klipper3d/klipper#6247

https://github.com/cloakedcode/klipper/blob/work-annex-probe/klippy/extras/dockable_probe.py

Unfortunately, I can't really help...

[EDIT] found another recently updated probe :

https://github.com/viesturz/klipper-toolchanger/blob/main/klipper/extras/tool_probe.py

Keep in mind I don't use KnobProbe as it is intended to be used (as CNC Z probe if I understand correctly) ; I tweaked it to be a nozzle probe and a reference point for measuring variations in the Z offset (nozzle Z - probe triggering point Z). Based on a standard Voron Z endstop. It works fine as a Z endstop, along with the virtual endstop. I don't have a tool changer.

@yet-another-average-joe
Copy link
Author

yet-another-average-joe commented Jun 15, 2024

I had time for tinkering with the new probe...
Remembered that knobprobe is based on probe. Using winmerge on one side (comparing probe and knobprobe), I created a new knobprobe, and edited it so the code looks similar to what the "old" knobprobe is doing.
At this point, I just verified that knobprobe is recognized, and reports valid information with QUERY_KNOBPROBE. Success.
Maybe is it a good starting point ? Too late for testing the other commands. It's 4:00 AM where I live. Sleepy...

knobprobe.zip

@yet-another-average-joe
Copy link
Author

yet-another-average-joe commented Jun 17, 2024

Reworked the "stock" probe, and turned it into a knobprobe. Seems to be working as expected.

Just one detail : I don't remember if the toolhead is supposed to go back to its initial position after the command "KNOBPROBE"... The new knobprobe doesn't, and stops with the probe "TRIGGERED" (no big deal). Remember I didn't use it as you do, and added code for auto Z offset in PRINT_START + auto SET_GCODE_OFFSET, with more attributes in printer.cfg, and a calibration command that saves the reference value into printer.cfg

The archive contains a working knobprobe, not the auto Z offset plugin (somme more testing to do and features to add )

knobprobe.zip

The results with Klipper v0.12.0-239-g433fcb6f :

knobprobe

@TypQxQ
Copy link
Owner

TypQxQ commented Jun 17, 2024 via email

@TypQxQ
Copy link
Owner

TypQxQ commented Jun 19, 2024

Really good work @yet-another-average-joe! Thank you!
I had hoped to have time but, kids and life....
I tested it and it works as expected. Thank you!
I just edited the headers so Kevin won't get blamed for the code and published it.

Reworked the "stock" probe, and turned it into a knobprobe. Seems to be working as expected.

@TypQxQ TypQxQ closed this as completed Jun 19, 2024
@yet-another-average-joe
Copy link
Author

Great !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants