Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openssl and httr should be imported, not suggested #6

Open
michbur opened this issue Nov 16, 2019 · 1 comment
Open

openssl and httr should be imported, not suggested #6

michbur opened this issue Nov 16, 2019 · 1 comment

Comments

@michbur
Copy link

michbur commented Nov 16, 2019

No description provided.

@TymekDev
Copy link
Owner

Idea behind putting openssl and httr in "Suggests" was taken from httr. httr package has httpuv package in "Suggests", yet it is required to perform the OAuth authorization. Similarly we wanted to limit httr and openssl requirement only to the services that actually require OAuth.

I can see how this change could improve the package's integrity by providing access to every service without installing additional packages (httr and openssl). However, this change would come at cost of higher requirements for every non-OAuth service and would render using plain curl useless, thus preferably requiring a code refactoring to use httr for performing requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants