Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML Block Content Not Visible #3

Open
asdf1nit opened this issue Oct 17, 2022 · 2 comments
Open

HTML Block Content Not Visible #3

asdf1nit opened this issue Oct 17, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@asdf1nit
Copy link

HTML blocks in Rock have a 'Display from' date setting that controls when content is allowed to display on the website.

If you have set date set on this block, and the end\expire date is in the past, then no HTML content is displayed in Magnus even though there is content in the blocks HTML field.

It seems that Magnus should always display the content of the block even if it is past it's scheduled time to show on the website.
@asdf1nit asdf1nit changed the title HTML Block Content HTML Block Content Not Visible Oct 17, 2022
@jonedmiston
Copy link
Member

This was intentional behavior for Magnus v1. The HTML Block is pretty tricky. It needs to support versioning with multiple considerations:

  1. Start Date
  2. Expire Date
  3. Context Key
  4. Entity Ids

We'll move this up in terms of priority. I have something nearly ready, but I'm not sure it will be fully tested in time to make v1.

@jonedmiston jonedmiston added the enhancement New feature or request label Oct 17, 2022
@briankalwat
Copy link

+1 for this! 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jonedmiston @briankalwat @asdf1nit