Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Density settings seem to be ignored #76

Open
andrewminer opened this issue Oct 4, 2020 · 0 comments
Open

Density settings seem to be ignored #76

andrewminer opened this issue Oct 4, 2020 · 0 comments

Comments

@andrewminer
Copy link

  • DaVinci's Vessels version: 1.12-6.340
  • MovingWorld version: 1.12-6.342
  • Minecraft version: 1.12.2
  • Forge version: 14.23.5.2847

I've tried updating the S:material_densities setting in the .../config/MovingWorld/Main.cfg file to adjust the density of blocks, but the new settings are always ignored. No matter what I do, every block seems to have the default density of 0.34. Here's a shortened example of my settings:

    S:material_densities <
        "minecraft:dirt=1.3"  # ground
        "minecraft:iron_block=9.0"  # iron
        "minecraft:planks=0.75"  # wood
        "minecraft:sand=1.7"
        "minecraft:snow=0.8"
        "minecraft:stone=2.5"  # rock
        "minecraft:water=1.0"
        "minecraft:wool=1.3"  # cloth
    >

I've included one block per block material reported by MineTweaker's /mt blockmaterials list. The comments give the name of the material type when it differs from any particular block of that type.

I've also tried reading through the MovingWorld code to see where these configs actually get used, and, from what I can see, they don't. It looks like the materialDensities list is created with some defaults, but nothing ever copies those values over to the MaterialDensity class to actually get used anywhere.

Even if a fix isn't going to be readily available, it would be great to hear back about whether you agree this is a real bug so that I can let the players on my server know what to expect. Thanks!

cross-posted as TridentMC/DavincisVessels#346

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant