Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Models with experiment annotation that have parameters without bindings and without explicitly set start values in TransiEnt #15

Open
casella opened this issue Mar 9, 2024 · 0 comments

Comments

@casella
Copy link

casella commented Mar 9, 2024

Dear ThermoFluidStream developers,

please check the latest OpenModelica regression test report. There are a few TransiEnt models that fail since we fixed ticket OpenModelica/OpenModelica#10386.

According to the latest version of Modelica Specification, i.e., 3.6, when you simulate a model all parameters with fixed = true should have a binding equation (either provided as a default in the components, or set by modifiers when instantiating them). The only exception is parameters that have an explicitly set start attribute - in that case, if a binding equation is lacking, the start attribute is used to set the parameter value and a warning should be issued.

You can

  • add a default binding to the parameters in the component definitions, or
  • add an explicit bining when you instantiate the components or,
  • add an explicit start = 0 attribute to the parameters in the component definition, which will be used as a fallback value, with a warning being issued.

This will make those models compliant with the Modelica Specification in force, and get them running again in OpenModelica.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant