Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Allow recent versions of beartype #665

Open
1 task done
jettjaniak opened this issue Jul 10, 2024 · 6 comments
Open
1 task done

[Proposal] Allow recent versions of beartype #665

jettjaniak opened this issue Jul 10, 2024 · 6 comments
Labels
complexity-simple Simple issues, which may be good for beginners tooling Anything pertaining to outside tools used within the codebase

Comments

@jettjaniak
Copy link
Contributor

Proposal

Allow beartype>=0.15.0 in project dependencies

Motivation

It's hard and hacky to get a project setup that depends on TL and recent version of beartype

Pitch

change beartype==^0.14.1 to beartype>=0.14.1

Alternatives

change beartype==^0.14.1 to beartype==^0.18.5

Checklist

  • I have checked that there is no similar issue in the repo (required)
@bryce13950 bryce13950 added complexity-high Very complicated changes for people to address who are quite familiar with the code tooling Anything pertaining to outside tools used within the codebase labels Jul 22, 2024
@bryce13950
Copy link
Collaborator

Someone has inadvertently experimented with this, and it does seem like it is not going to be a trivial process. I don't know if it is going to be the most complicated task in the project, but there are quite a few pieces that need to be addressed. @jettjaniak Have you been able to find a relatively simple way to get everything working together, or is the current bear type version blocking a lot of productivity?

@jettjaniak
Copy link
Contributor Author

I'm using TL with new beartype version, it's working fine

@bryce13950
Copy link
Collaborator

@jettjaniak It may have been a different dependency that I am thinking of. I will try to update it to 0.18 now, and see if we have any major issues with that update.

@bryce13950 bryce13950 added complexity-simple Simple issues, which may be good for beginners and removed complexity-high Very complicated changes for people to address who are quite familiar with the code labels Jul 23, 2024
@bryce13950 bryce13950 mentioned this issue Jul 23, 2024
10 tasks
@bryce13950
Copy link
Collaborator

Alright! I think I was recalling a different tool when I posted my first comment. This upgrade was pretty trivial. It did require an update to dependencies for torch, so I am going to wait until the next feature release to put this into pip. If you need it right away, it will be in dev once the CI is done. The next feature release will be sooner rather than later though.

@bryce13950
Copy link
Collaborator

Well it was actually mypy that was the issue for the dependency update! That is still an issue, so I am reopening this one until those mypy changes are resolved.

@bryce13950 bryce13950 reopened this Jul 23, 2024
@jettjaniak
Copy link
Contributor Author

Thanks! So dev TL works with recent beartype now, but not with recent mypy?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity-simple Simple issues, which may be good for beginners tooling Anything pertaining to outside tools used within the codebase
Projects
None yet
Development

No branches or pull requests

2 participants