Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hafasLineId + hafasOperatorCode combination not distinct #26

Open
rnewhost opened this issue Sep 20, 2023 · 6 comments
Open

hafasLineId + hafasOperatorCode combination not distinct #26

rnewhost opened this issue Sep 20, 2023 · 6 comments
Labels
needs-discussion This issue / pull request needs to be discussed. specification Changes at specification

Comments

@rnewhost
Copy link
Contributor

I have an issue with lines REX 3 in Salzburg and the Ostregion (both in Austria). Both are operated by the ÖBB (and therefore have the same operator ID) and line ID rex-3. With these two parameters, the lines can't be distinguished.

The current version features the line colour for REX 3 in Salzburg (https://github.com/Traewelling/line-colors/blob/main/line-colors.csv#L87), which is also shown for REX 3 in the Ostregion (see screenshots from Träwelldroid attached)

I suggest adding an optional parameter to set one of more allowed ranges for "fahrtNr", as all trains for REX 3 in Salzburg operate in the range 1500-1599, 25500-25599 and 31500-31599 and in the Ostregion between 2200-2299 and 29200-29299.


Screenshot_2023-09-20-14-24-41-98_6eaab5f62e0cb9204f88373d41d52439

Screenshot_2023-09-20-14-24-58-07_6eaab5f62e0cb9204f88373d41d52439

@jheubuch
Copy link
Collaborator

WOULD YOU PLEASE NOT FIND SUCH DAMN EDGE CASES 😂🥺😭

@jheubuch jheubuch added specification Changes at specification needs-discussion This issue / pull request needs to be discussed. labels Sep 20, 2023
@oneiricbotcelot
Copy link
Contributor

oneiricbotcelot commented Oct 23, 2023

I found another case where the same problem occurs: HAFAS line rb-41 operated by db-regio-ag-mitte.

RB 41 Treysa – Stadtallendorf – Marburg – Gießen – Friedberg – Frankfurt(Main) Hbf
RB 41 Karlsruhe Hbf – Rastatt – Forbach

The second line is green according to DB Regio whereas the first one should be purple according to RMV.

At the moment both are displayed as green.

@Unterwerk
Copy link
Contributor

four more cases are RE4, RE7, RB23 and RB24 of DB Regio Nordost. All lines currently have the colour of the line in Berlin/Brandenburg and not of Mecklenburg-Vorpommern.

@jonasr97
Copy link
Contributor

I also had the problem with RE4-BB and RE4-MV. The only way to differentiate both is the "adminCode".

@sebiIO
Copy link
Member

sebiIO commented Jun 14, 2024

The RB 16 and RE 16 lines of db-regio-bayern also share the same id 3-800765-16, but can be distinguished by the line name.

@metrophil
Copy link
Contributor

This is also a problem now for the RS3 lines of Regio-S-Bahn Donau-Iller and Regio-S-Bahn Ortenau as they are both swe-rs3 operated by sweg-sudwestdeutsche-landesverkehrs-gmbh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-discussion This issue / pull request needs to be discussed. specification Changes at specification
Projects
None yet
Development

No branches or pull requests

7 participants