-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hafasLineId + hafasOperatorCode combination not distinct #26
Comments
WOULD YOU PLEASE NOT FIND SUCH DAMN EDGE CASES 😂🥺😭 |
I found another case where the same problem occurs: HAFAS line rb-41 operated by db-regio-ag-mitte.
The second line is green according to DB Regio whereas the first one should be purple according to RMV. At the moment both are displayed as green. |
four more cases are RE4, RE7, RB23 and RB24 of DB Regio Nordost. All lines currently have the colour of the line in Berlin/Brandenburg and not of Mecklenburg-Vorpommern. |
I also had the problem with RE4-BB and RE4-MV. The only way to differentiate both is the "adminCode". |
The RB 16 and RE 16 lines of db-regio-bayern also share the same id |
This is also a problem now for the RS3 lines of Regio-S-Bahn Donau-Iller and Regio-S-Bahn Ortenau as they are both swe-rs3 operated by sweg-sudwestdeutsche-landesverkehrs-gmbh |
I have an issue with lines REX 3 in Salzburg and the Ostregion (both in Austria). Both are operated by the ÖBB (and therefore have the same operator ID) and line ID rex-3. With these two parameters, the lines can't be distinguished.
The current version features the line colour for REX 3 in Salzburg (https://github.com/Traewelling/line-colors/blob/main/line-colors.csv#L87), which is also shown for REX 3 in the Ostregion (see screenshots from Träwelldroid attached)
I suggest adding an optional parameter to set one of more allowed ranges for "fahrtNr", as all trains for REX 3 in Salzburg operate in the range 1500-1599, 25500-25599 and 31500-31599 and in the Ostregion between 2200-2299 and 29200-29299.
The text was updated successfully, but these errors were encountered: