-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User shouldn't notice it when he gets deleted from contact list #9
Comments
This is the default behaviour. In what circumstance would this not be the case? |
@JFreegman: Yes, it's the default behaviour. But the clients could implement that you can see it if you got deleted. Because of that, I thought it would make sense to add it to the Tox-Client-Standard. |
The deleting client would have to be the one to send a notification about friend deletion. |
If the protocol hasn't changed since irungentoo/toxcore#1427, in theory it's still possible for a client with patched toxcore to detect accurately when they get deleted by a friend, because empirically that's pretty much the only time we get a PACKET_ID_OFFLINE. I'm not convinced we need to add that in the TCS, but if things haven't changed, it's technically possible. |
This seems like incorrect behaviour. I don't see why it should be necessary to send any information to a friend you're deleting. I'm going to make a pull request to remove this. |
@JFreegman irungentoo/toxcore#1427 (comment) If I understand him right, if you are removing a friend from your friend list and you are also in the same group chat with the friend -- you won't timeout. |
Oh so it's a hack due to the old groupchat implementation? Well let's get those new groupchats finished then. |
Assume Alice and Bob are friends.
Bob deletes Alice from his contact list.
Desired behaviour: It looks for Alice like Bob is just going offline.
Should be required for all clients.
The text was updated successfully, but these errors were encountered: