Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User shouldn't notice it when he gets deleted from contact list #9

Open
ovalseven8 opened this issue Oct 17, 2015 · 7 comments
Open

Comments

@ovalseven8
Copy link
Contributor

Assume Alice and Bob are friends.

Bob deletes Alice from his contact list.
Desired behaviour: It looks for Alice like Bob is just going offline.

Should be required for all clients.

@JFreegman
Copy link
Member

This is the default behaviour. In what circumstance would this not be the case?

@ovalseven8
Copy link
Contributor Author

@JFreegman: Yes, it's the default behaviour. But the clients could implement that you can see it if you got deleted. Because of that, I thought it would make sense to add it to the Tox-Client-Standard.

@stal888
Copy link
Collaborator

stal888 commented Oct 18, 2015

The deleting client would have to be the one to send a notification about friend deletion.

@tux3
Copy link

tux3 commented Dec 4, 2015

If the protocol hasn't changed since irungentoo/toxcore#1427, in theory it's still possible for a client with patched toxcore to detect accurately when they get deleted by a friend, because empirically that's pretty much the only time we get a PACKET_ID_OFFLINE.

I'm not convinced we need to add that in the TCS, but if things haven't changed, it's technically possible.

@JFreegman
Copy link
Member

because empirically that's pretty much the only time we get a PACKET_ID_OFFLINE.

This seems like incorrect behaviour. I don't see why it should be necessary to send any information to a friend you're deleting.

I'm going to make a pull request to remove this.

@nurupo
Copy link
Member

nurupo commented Dec 5, 2015

@JFreegman irungentoo/toxcore#1427 (comment)

If I understand him right, if you are removing a friend from your friend list and you are also in the same group chat with the friend -- you won't timeout.

@JFreegman
Copy link
Member

Oh so it's a hack due to the old groupchat implementation? Well let's get those new groupchats finished then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants