Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More logging while cancelling Flink jobs #7289

Merged
merged 1 commit into from
Dec 6, 2024
Merged

More logging while cancelling Flink jobs #7289

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...nk/management/src/main/scala/pl/touk/nussknacker/engine/management/FlinkRestManager.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,9 @@ class FlinkRestManager(
s"Trying to cancel $processName${deploymentId.map(" with id: " + _).getOrElse("")} which is not present or finished on Flink."
)
Future.successful(())
case single :: Nil => cancelFlinkJob(single)
case single :: Nil =>
logger.info(s"Cancelling Flink job with deploymentId: ${single.externalDeploymentId.getOrElse("")}.")
cancelFlinkJob(single)
case moreThanOne @ (_ :: _ :: _) =>
logger.warn(
s"Found duplicate jobs of $processName${deploymentId.map(" with id: " + _).getOrElse("")}: $moreThanOne. Cancelling all in non terminal state."
Expand Down Expand Up @@ -233,6 +235,7 @@ class FlinkRestManager(
deploymentId: ExternalDeploymentId,
savepointDir: Option[String]
): Future[SavepointResult] = {
logger.debug(s"Stopping Flink job: ${deploymentId.value}.")
client.stop(deploymentId, savepointDir)
}

Expand Down
Loading