Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NU-1701] Casts suggester #6974

Merged
merged 5 commits into from
Oct 4, 2024
Merged

[NU-1701] Casts suggester #6974

merged 5 commits into from
Oct 4, 2024

Conversation

lukasz-bigorajski
Copy link
Contributor

Describe your changes

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@lukasz-bigorajski lukasz-bigorajski force-pushed the nu.1701.casts.suggester.2 branch from d9ba90f to f7330cc Compare October 3, 2024 15:08
@lukasz-bigorajski lukasz-bigorajski marked this pull request as ready for review October 3, 2024 15:08
@github-actions github-actions bot added the docs label Oct 3, 2024
mk-software-pl
mk-software-pl reviewed Oct 4, 2024
View reviewed changes
docs/scenarios_authoring/Spel.md Show resolved Hide resolved
...va/pl/touk/nussknacker/engine/spel/internal/ConversionAndExtensionAwareMethodsDiscovery.java Show resolved Hide resolved
...java/pl/touk/nussknacker/engine/spel/internal/ConversionAndExtensionsAwareMethodInvoker.java Show resolved Hide resolved
scenario-compiler/src/main/scala/pl/touk/nussknacker/engine/extension/Cast.scala Outdated Show resolved Hide resolved
scenario-compiler/src/main/scala/pl/touk/nussknacker/engine/extension/Cast.scala Outdated Show resolved Hide resolved
...java/pl/touk/nussknacker/engine/spel/internal/ConversionAndExtensionsAwareMethodInvoker.java Show resolved Hide resolved
scenario-compiler/src/main/scala/pl/touk/nussknacker/engine/util/classes/Extensions.scala Outdated Show resolved Hide resolved
scenario-compiler/src/main/scala/pl/touk/nussknacker/engine/util/classes/Extensions.scala Show resolved Hide resolved
...java/pl/touk/nussknacker/engine/spel/internal/ConversionAndExtensionsAwareMethodInvoker.java Show resolved Hide resolved
scenario-compiler/src/main/scala/pl/touk/nussknacker/engine/spel/SpelExpressionSuggester.scala Outdated Show resolved Hide resolved
Łukasz Bigorajski added 2 commits October 4, 2024 16:23
mk-software-pl
mk-software-pl approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@mk-software-pl mk-software-pl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some minor comments.

but it LGTM!

scenario-compiler/src/main/scala/pl/touk/nussknacker/engine/extension/Cast.scala Show resolved Hide resolved
scenario-compiler/src/main/scala/pl/touk/nussknacker/engine/extension/ExtensionMethods.scala Outdated Show resolved Hide resolved
scenario-compiler/src/main/scala/pl/touk/nussknacker/engine/extension/ExtensionMethods.scala Outdated Show resolved Hide resolved
@github-actions github-actions bot mentioned this pull request Oct 4, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024

created: #6986
⚠️ Be careful! Snapshot changes are not necessarily the cause of the error. Check the logs.

@lukasz-bigorajski lukasz-bigorajski merged commit 353e063 into staging Oct 4, 2024
18 checks passed
@lukasz-bigorajski lukasz-bigorajski deleted the nu.1701.casts.suggester.2 branch October 4, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mk-software-pl mk-software-pl mk-software-pl approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukasz-bigorajski @mk-software-pl