Skip to content
Pull Request Labeler

[NU-1836] Move converters from CONV util to extension methods. Implement generic conversion extension methods: is, to and toOrNull. #15037

Sign in to view logs

[NU-1836] Move converters from CONV util to extension methods. Implement generic conversion extension methods: is, to and toOrNull.

[NU-1836] Move converters from CONV util to extension methods. Implement generic conversion extension methods: is, to and toOrNull. #15037

Triggered via pull request October 23, 2024 06:54
@lukasz-bigorajskilukasz-bigorajski
opened #7063
Status Success
Total duration 12s
Artifacts –

labeler.yml

on: pull_request_target
triage
3s
triage
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 2 warnings
pl.touk.nussknacker.ui.api.ExpressionSuggesterSpec ► should suggest parameters for casts methods: designer/server/src/test/scala/pl/touk/nussknacker/ui/api/ExpressionSuggesterSpec.scala#L783
Failed test found in: designer/server/target/test-reports/TEST-pl.touk.nussknacker.ui.api.ExpressionSuggesterSpec.xml Error: org.scalatest.exceptions.TestFailedException: List() did not contain the same elements as List(ExpressionSuggestion("String", TypedClass(class java.lang.String, List()), false, None, List()), ExpressionSuggestion("Duration", TypedClass(class java.time.Duration, List()), false, None, List()), ExpressionSuggestion("LocalDateTime", TypedClass(class java.time.LocalDateTime, List()), false, None, List()), ExpressionSuggestion("Map", TypedClass(interface java.util.Map, List(Unknown, Unknown)), false, None, List()), ExpressionSuggestion("A", TypedClass(class pl.touk.nussknacker.ui.api.A, List()), false, None, List()), ExpressionSuggestion("AA", TypedClass(class pl.touk.nussknacker.ui.api.AA, List()), false, None, List()), ExpressionSuggestion("B", TypedClass(class pl.touk.nussknacker.ui.api.B, List()), false, None, List()), ExpressionSuggestion("C", TypedClass(class pl.touk.nussknacker.ui.api.C, List()), false, None, List()), ExpressionSuggestion("Util", TypedClass(class pl.touk.nussknacker.ui.api.Util, List()), false, None, List()), ExpressionSuggestion("WithList", TypedClass(class pl.touk.nussknacker.ui.api.WithList, List()), false, None, List()))
pl.touk.nussknacker.engine.extension.ExtensionMethodsSpec ► should add extension methods to already existing definitions in ClassDefinitionSet: scenario-compiler/src/test/scala/pl/touk/nussknacker/engine/extension/ExtensionMethodsSpec.scala#L34
Failed test found in: scenario-compiler/target/test-reports/TEST-pl.touk.nussknacker.engine.extension.ExtensionMethodsSpec.xml Error: org.scalatest.exceptions.TestFailedException: Map("java.lang.String" -> Set("toUpperCase"), "java.lang.Object" -> Set("toString", "is", "to", "toOrNull")) was not equal to Map("java.lang.String" -> Set("toUpperCase"), "java.lang.Object" -> Set("toString", "canCastTo", "castTo", "castToOrNull"))
triage
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/labeler@v3. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
triage
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/labeler@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/