Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The worker does not stop when errors are raised during a bulk run #371

Open
DanicaSTFC opened this issue Oct 16, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@DanicaSTFC
Copy link
Contributor

DanicaSTFC commented Oct 16, 2024

When runing a bulk run, this error occurs

raise ValueError('No points in pointcloud')

When these errors are raised the worker should stop but instead the whole app freezes. The terminal has the following error:

No points in pointcloud

To replicate this bug:

The height of the mask can be +-500 planes, but it does not matter.
Set few points in "Points in run" e.g. 100

An example of bulk parameters:
Image

Proposed solution

A new pointcloud is created for each subvolume size

if not self.createPointCloud(filename=filename, subvol_size=int(pc_subvol_size),

def createPointCloud(self, **kwargs):

It seems that sometimes the points are set to 0 in

https://github.com/TomographicImaging/CILViewer/blob/076cfb9381425ab225c8c6fc64a5332940c63977/Wrappers/Python/ccpi/viewer/utils/visualisation_pipeline.py#L256

As a temporary fix, the worker should be stopped and raise a warning rather than freeze

Some more info on pointcloud in #90

@DanicaSTFC DanicaSTFC added the bug Something isn't working label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

1 participant