Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the meta.yaml for cuda #5

Open
gfardell opened this issue Feb 21, 2024 · 2 comments
Open

Update the meta.yaml for cuda #5

gfardell opened this issue Feb 21, 2024 · 2 comments

Comments

@gfardell
Copy link
Member

We are handling the cuda dependency incorrectly.

Based on https://github.com/conda-forge/cuda-version-feedstock/blob/main/recipe/README.md
I believe our meta.yaml should be something like:

requirements:
  host:
    - cuda-version =X.Y
  run:
    - __cuda >={{X}}.0
    {% if X>= 12 %}
    - cuda-version >=X,<X+1
    {% else %}
    - cudatoolkit >=X,<X+1
    {% endif %}

where __cuda sets the minimum driver requirement from the user.

And cuda-version or cudatoolkit handle the cudart version.

I'm surprised at the lose requirement for cudatoolkit/cuda-version as I expected us to need the correct minor version of cudart. It might need trying cxomparing with pin_compatible

@gfardell
Copy link
Member Author

gfardell commented Sep 9, 2024

Enforcing __cuda has knock on effects for the docker build, which needs to include tigre, but cannot if __cuda is enforced as a virtual package.

@gfardell
Copy link
Member Author

gfardell commented Sep 9, 2024

When we build with CUDA SDK > 12 we need to confirm cudart libraries are included in the distribution with cuda-version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant